Jaro
Jaro
You're right. Can anyone give me some tips on how to profile HLS to see where these timeouts are coming from?
Ah, I was thinking there was some inefficiency somewhere that only GHC 9.6 and later could properly optimize. However, I think you're suggesting an alternative explanation: that one of the...
I've decided to make the tests ignore all error codes on GHC 9.4. I think some errors already have codes in 9.4, so we could do a bit more, but...
The remaining MacOS failure seems like a compiler bug. The linker is throwing an error. Edit: https://gitlab.haskell.org/ghc/ghc/-/issues/24648 Adding the compiler flag `-ld_classic` might be a workaround.
@fendor do you think we could try setting the `-ld_classic` flag? If so, where should I put it?
Oh, I see we already have that exact workaround in some places. I'll just copy that to the hlint plugin.
Yay, it has finally passed CI! Should I squash the commits? I'm not sure what to write in the message as I don't really know the details of what exactly...
Great! If you just want to see the changes I made to Dylan's work, you can use this link https://github.com/haskell/haskell-language-server/pull/4433/files/6ca2a196caa89f2de3452f0afc5a41299a94e092..1f835dabecec0ed6cd2e9236fc766a0e01620e41
One thing I don't understand is what the final codes actually are. When we construct them it seems to include the `GHC-` prefix: https://github.com/haskell/haskell-language-server/pull/4433/files#diff-15ac916db5d1445c16a0cb4a644ecc44854ce21d0f648b07663212035766b1feR101-R121 But when we use `requireDiagnostic` we...
Interesting, it seems the stack build converts more warnings to errors than the cabal build.