tiny-care-terminal icon indicating copy to clipboard operation
tiny-care-terminal copied to clipboard

Show daily, weekly and monthly pomodoro history 🍅

Open gauravchl opened this issue 7 years ago • 3 comments

screen shot 2017-08-20 at 4 37 50 pm

Uses node-storage to keep track of pomodoro history. Stores each pomodoro with it's start and end date.

cc: https://github.com/notwaldorf/tiny-care-terminal/issues/113

gauravchl avatar Aug 20 '17 11:08 gauravchl

@gauravchl Thanks for contributing!

My problem is that this cool new feature would complicates the core.js even more. @notwaldorf and I would like to keep the project as easy and readable as possible. In the long run we should try to reduce complexity and not overload the core with new features.

What do you think about some kind of a plug-in system where we move all this weather and twitter stuff to seperate modules. Especially the pomodoro feature would be a nice candidate to reduce complexity!

At the moment I would prefer not to merge it :crying_cat_face:

mojoaxel avatar Mar 14 '18 20:03 mojoaxel

@mojoaxel

What do you think about some kind of a plug-in system

This is great, i like it.

Currently The Pomodoro logic is already inside pomodoro.js, some of the code related to Pomodoro inside care.js is(ie: key bindings...) just to provide connectivity between those two modules. I've some ideas to abstract Pomodoro feature further, will try those.

I'm thinking to use ES6 to improve code readability, structure and reduce some complexity. What do you think?

gauravchl avatar Mar 22 '18 10:03 gauravchl

I'm thinking to use ES6 to improve code readability, structure and reduce some complexity. What do you think?

I personally have no problem using ES6 but please make sure to enforce the needed node.js version in package.json and DON'T change the existing code to ES6. Just use it for new modules.

By the way: It is still @notwaldorf project and I'm not going to merge big changes without her approving them.

mojoaxel avatar Mar 22 '18 20:03 mojoaxel