emoji-selector icon indicating copy to clipboard operation
emoji-selector copied to clipboard

Add npm support, mostly.

Open justinfagnani opened this issue 8 years ago • 8 comments

PR not for merging, at least yet. Just showing the changes needed to use Polymer and elements via npm.

justinfagnani avatar Feb 03 '16 01:02 justinfagnani

Perhaps worth landing in a branch so we can reference?

addyosmani avatar Feb 03 '16 18:02 addyosmani

Can't my fork be used for that?

justinfagnani avatar Feb 03 '16 18:02 justinfagnani

If your fork is staying around then yes :)

addyosmani avatar Feb 03 '16 18:02 addyosmani

My fork's more likely to stick around than a branch. I'm not sure if @notwaldorf is interested in merging this or not so that it can serve as the reference for a while.

justinfagnani avatar Feb 03 '16 18:02 justinfagnani

I have nothing against merging this, but the description says very clearly I shouldn't :)

notwaldorf avatar Feb 03 '16 18:02 notwaldorf

Well, I wasn't sure it was ready before, but I'm pretty sure it is now. I'm still playing with some things though, so there's no rush.

justinfagnani avatar Feb 04 '16 02:02 justinfagnani

Just started reviewing :)

:octocat: Sent from GH.

(sorry for the automated comment from GH :P)

robdodson avatar Feb 06 '16 23:02 robdodson

Instructions on getting it to run:

npm install
gulp browser_modules
npm install -g polyserve (to make sure you have latest version)
polyserve -c browser_modules -n emoji-selector
open http://localhost:8080/components/emoji-selector/demo/index.html in browser

robdodson avatar Feb 06 '16 23:02 robdodson