editorconfig-tools icon indicating copy to clipboard operation
editorconfig-tools copied to clipboard

fails when given a lot of files

Open notslang opened this issue 9 years ago • 3 comments

it seems that the editorconfig package reads the .editorconfig file every time it is queried, so even with graceful-fs, being used in our package, the editorconfig package goes over the limit of the maximum number of files to read at once.

notslang avatar Nov 01 '14 21:11 notslang

It sounds like the nature of the tool to me, because you can have many .editorconfig files in a project. I don't see any way to fix it. Might be a wontfix.

jednano avatar Mar 18 '15 18:03 jednano

It might be a wontfix in this package, but it should be very simple to fix in the editorconfig package, just by doing some caching. It might need to be implemented as a special bulk resolver function, so caching doesn't cause issues in the rare case that an .editorconfig file is actually supposed to change between calls, but it should be totally doable.

notslang avatar Mar 18 '15 18:03 notslang

Yeah. That sounds fixable. The issue should be opened there.

jednano avatar Mar 18 '15 19:03 jednano