create-react-app-redux icon indicating copy to clipboard operation
create-react-app-redux copied to clipboard

Connected-react-router v6 breaking this app

Open deksden opened this issue 5 years ago • 3 comments

Migrating from v4 to v5 (v6) is breaking app.

Here is FAQ with instruction how to migrate: https://github.com/supasate/connected-react-router/blob/master/FAQ.md#how-to-migrate-from-v4-to-v5

deksden avatar Jan 16 '19 08:01 deksden

"connected-react-router": "^6.2.1",
"react-redux": "^6.0.0",

Tried running with the above versions of connected-react-router and react-redux and the app keeps throwing the following error. Could not find router reducer in state tree, it must be mounted under "router". After updating the Migration to v5 and v6 the app works but when I add a customContext to the provider and connectedRouter the following error. Could not find "store" in the context of "Connect(Home)". Either wrap the root component in a <Provider>, or pass a custom React context provider to <Provider> and the corresponding React context consumer to Connect(Home) in connect options. I've opened a issue on the connected-react-router repo (https://github.com/supasate/connected-react-router/issues/241)

vchouhan avatar Jan 19 '19 01:01 vchouhan

yeah I hit this exact problem. the joys of the react ecosystem thrash, everything breaks 15 minutes later.

dcsan avatar Jan 24 '19 09:01 dcsan

@vchouhan have you seen https://github.com/notrab/create-react-app-redux/pull/71 ?

It might be worth checking out that branch, confirming it works and then we can push it into master.

notrab avatar Jan 24 '19 16:01 notrab