java-apns icon indicating copy to clipboard operation
java-apns copied to clipboard

For discussion: Replacing jackson with a simpler JSON implementation

Open marcdejonge opened this issue 9 years ago • 3 comments

Hi,

I'm having trouble in my setup with all the jackson dependancies. I propose to use the simple JSON implementation from https://github.com/douglascrockford/JSON-java.

This version builds and runs fine for me, although I do have a deadlock in the 'sendOneSimpleClientCertFail' test (I'm ignoring it right now, because it seems to work fine outside of tests).

marcdejonge avatar Dec 15 '15 10:12 marcdejonge

I don't like the restrictive nature of the license:

https://github.com/douglascrockford/JSON-java/blob/master/JSONArray.java#L16

On Tue, Dec 15, 2015 at 11:13 AM, Marc de Jonge [email protected] wrote:

Hi,

I'm having trouble in my setup with all the jackson dependancies. I propose to use the simple JSON implementation from https://github.com/douglascrockford/JSON-java.

This version builds and runs fine for me, although I do have a deadlock in the 'sendOneSimpleClientCertFail' test (I'm ignoring it right now, because

it seems to work fine outside of tests).

You can view, comment on, or merge this pull request online at:

https://github.com/notnoop/java-apns/pull/279 Commit Summary

  • Replaced jackson with a simples JSON implementation

File Changes

  • M pom.xml https://github.com/notnoop/java-apns/pull/279/files#diff-0 (14)
  • M src/main/java/com/notnoop/apns/PayloadBuilder.java https://github.com/notnoop/java-apns/pull/279/files#diff-1 (7)
  • A src/main/java/com/notnoop/json/CDL.java https://github.com/notnoop/java-apns/pull/279/files#diff-2 (279)
  • A src/main/java/com/notnoop/json/Cookie.java https://github.com/notnoop/java-apns/pull/279/files#diff-3 (169)
  • A src/main/java/com/notnoop/json/CookieList.java https://github.com/notnoop/java-apns/pull/279/files#diff-4 (89)
  • A src/main/java/com/notnoop/json/HTTP.java https://github.com/notnoop/java-apns/pull/279/files#diff-5 (163)
  • A src/main/java/com/notnoop/json/HTTPTokener.java https://github.com/notnoop/java-apns/pull/279/files#diff-6 (77)
  • A src/main/java/com/notnoop/json/JSONArray.java https://github.com/notnoop/java-apns/pull/279/files#diff-7 (1145)
  • A src/main/java/com/notnoop/json/JSONException.java https://github.com/notnoop/java-apns/pull/279/files#diff-8 (69)
  • A src/main/java/com/notnoop/json/JSONML.java https://github.com/notnoop/java-apns/pull/279/files#diff-9 (469)
  • A src/main/java/com/notnoop/json/JSONObject.java https://github.com/notnoop/java-apns/pull/279/files#diff-10 (1848)
  • A src/main/java/com/notnoop/json/JSONString.java https://github.com/notnoop/java-apns/pull/279/files#diff-11 (43)
  • A src/main/java/com/notnoop/json/JSONStringer.java https://github.com/notnoop/java-apns/pull/279/files#diff-12 (78)
  • A src/main/java/com/notnoop/json/JSONTokener.java https://github.com/notnoop/java-apns/pull/279/files#diff-13 (446)
  • A src/main/java/com/notnoop/json/JSONWriter.java https://github.com/notnoop/java-apns/pull/279/files#diff-14 (327)
  • A src/main/java/com/notnoop/json/Property.java https://github.com/notnoop/java-apns/pull/279/files#diff-15 (72)
  • A src/main/java/com/notnoop/json/XML.java https://github.com/notnoop/java-apns/pull/279/files#diff-16 (492)
  • A src/main/java/com/notnoop/json/XMLTokener.java https://github.com/notnoop/java-apns/pull/279/files#diff-17 (365)
  • M src/test/java/com/notnoop/apns/PayloadBuilderTest.java https://github.com/notnoop/java-apns/pull/279/files#diff-18 (28)
  • M src/test/java/com/notnoop/apns/integration/ApnsConnectionTest.java https://github.com/notnoop/java-apns/pull/279/files#diff-19 (2)

Patch Links:

  • https://github.com/notnoop/java-apns/pull/279.patch
  • https://github.com/notnoop/java-apns/pull/279.diff

— Reply to this email directly or view it on GitHub https://github.com/notnoop/java-apns/pull/279.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf

matzew avatar Dec 15 '15 11:12 matzew

But it's a joke, right?

marcdejonge avatar Dec 15 '15 11:12 marcdejonge

:-) yeah

matzew avatar Dec 21 '15 09:12 matzew