Laxman

Results 38 comments of Laxman

The ToC item "Model zoo" in you example links to `#model-zoo`, but the actual heading has an ID of `#model-zoo-` because of the extra `` you have at the end.

It still does fail for the rest once you fix the first item, either way you should probably fix IDs in the ToC. Also, yeah I think this is a...

We can keep this open as this module _probably should_ handle HTML inside headings similar to what GitHub does. I'd leave this one out to the maintainers though.

Not sure if everyone includes PR numbers in the merge commit title though (squash or otherwise). Apart from that, this would be awesome, people also use major, minor, and patch...

Should `exclude` be handled by labels too?

> I think tittle-based exclusion is still useful and flexible (since it works on non-PR commits) That makes sense.

![image](https://user-images.githubusercontent.com/37769974/93906459-d81cd780-fd19-11ea-8093-dd95b55414c8.png) This is going to be a problem, inputs can only be "string", "boolean", or "number", especially with `core.getInput()` using environment variables for passing around inputs. https://github.com/actions/toolkit/blob/da34bfb74d2827749824ce21f0d3d74a412d7fbf/packages/core/src/core.ts#L69-L77

Does this work? ``` yml labels: | { "bug": "Bugs", "breaking change": "Breaking changes" } ``` Or something similar? Sheesh, JSON inside YAML looks weird as hell!

The first couple issues are almost resolved by #3, but yes, we need more documentation. Edit: Also needs updated screenshot as per #5.

> This happens: > > ``` > Using pushed tag as reference: v1.2.0 > Computed range: v1.1.1..v1.2.0 > ##[error]Validation Failed: {"resource":"Release","code":"already_exists","field":"tag_name"} > ``` Because IMO failing with an error is...