Lee Moody
Lee Moody
Here's a diff which I _think_ would solve the problem. Happy to PR if you agree 😄 ```diff diff --git a/src/parser.js b/src/parser.js index c00d04b..ceb71f8 100644 --- a/src/parser.js +++ b/src/parser.js @@...
Ah so we're using `@fastly/js-compute` to build a package to `fastly/c-at-e/pkg`: https://github.com/Financial-Times/polyfill-service/blob/d1cad0a5f0617133edec2302a48deb8e183a509a/fastly/c-at-e/package.json#L8 But that was removed in 0.3.0: https://github.com/fastly/js-compute-runtime/pull/108 Looks like we can use the fastly cli instead: https://developer.fastly.com/reference/cli/compute/
Good morning @JakeChampion. Do you mind if I ask you a polyfill.io / Fastly c@e question? Looks like to upgrade `js-compute-runtime` we're going to need to update the [build script](https://github.com/Financial-Times/polyfill-service/blob/d1cad0a5f0617133edec2302a48deb8e183a509a/fastly/c-at-e/package.json#L8)...
See https://github.com/Financial-Times/polyfill-service/pull/2712/
> I think adding a `themable` option to the formats that support it sounds like pretty good idea. It would be a pretty minor change. @chazzmoney thoughts? Plus one 👍...
>The scss/map-deep will output a list of SCSS variables with !default flag and a SCSS map which uses the previously defined variables. Hey, I just opened a PR to add...
Thinking about the output order != source order issue: if we could avoid techniques like splitting with comments, we'd be able to use Sass placeholders safety and reduce our bundle...
> > If we are able to split out styles for the header, footer and navigation then we'd be in a pretty good place. > > 💯 that would be...
I'm curious why the root font size is 0.8125em too? We should probably explicitly set `16px` unless we are able to use relative units consistently (much preferable). Some Origami components...
I see, thanks for the context @CLTPayne! I'd say let's poke this bear because`0.8125em` is currently causing layout bugs on ft.com and will cause issues for any user who has...