notion-repackaged icon indicating copy to clipboard operation
notion-repackaged copied to clipboard

Apple M1 build is "damaged"

Open jamezrin opened this issue 3 years ago • 20 comments

Seems to be an issue of electron-builder: https://github.com/electron-userland/electron-builder/issues/5850

jamezrin avatar Jul 12 '21 21:07 jamezrin

I came to open that issue :)

fharper avatar Jul 21 '21 18:07 fharper

I came to open that issue :)

🔔 : I switch to use notion-enhancer instead of notion-repackaged, beacause the damaged Apple M1 build

  1. uninstall/reinstall notion to refresh it

  2. if the enhancer is already installed, run notion-enhancer apply -y. otherwise, run npm i -g notion-enhancer.

  3. replace line 108 of notion-enhancer/mods/core/client.js with !document.querySelector('.notion-topbar > div[style*="display: flex"]')

  4. add the following to line 19 of notion-enhancer/mods/core/createWindow.js:

    __exports.getIndexUrl = require(`${helpers
        .getNotionResources()
        .replace(/\\/g, '/')}/app/helpers/urlHelpers.js`).getIndexUrl;
    
  5. if on a newer version of macOS and you get a permissions error when opening the app, run codesign --force --deep --sign - /Applications/Notion.app

wujunchuan avatar Jul 22 '21 01:07 wujunchuan

🔔 : I switch to use notion-enhancer instead of notion-repackaged, beacause the damaged Apple M1 build

It's what I did also, but thanks for sharing!

fharper avatar Jul 22 '21 10:07 fharper

when I used Notion-Enhanced-2.0.16-1-arm64.dmg it also said it was damaged, but when I used Notion-Enhanced-2.0.16-1.dmg it only appeared as possible malware :)

scralt avatar Jul 30 '21 10:07 scralt

when I used Notion-Enhanced-2.0.16-1-arm64.dmg it also said it was damaged, but when I used Notion-Enhanced-2.0.16-1.dmg it only appeared as possible malware :)

The malware warning is possibly caused by the build not being signed, there is not much we can do about it. Can you run the normal build in m1 anyway? I assume thats Rosetta doing its thing, does it work well?

jamezrin avatar Jul 30 '21 10:07 jamezrin

when I used Notion-Enhanced-2.0.16-1-arm64.dmg it also said it was damaged, but when I used Notion-Enhanced-2.0.16-1.dmg it only appeared as possible malware :)

The malware warning is possibly caused by the build not being signed, there is not much we can do about it. Can you run the normal build in m1 anyway? I assume thats Rosetta doing its thing, does it work well?

oh yes you can easily bypass the malware warning, i didn't mean to prose it as an issue. works perfectly :)

scralt avatar Jul 30 '21 10:07 scralt

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Sep 14 '21 02:09 github-actions[bot]

@jamezrin I tried installing older versions: Notion v2.0.16-1, v2.0.16-2, v2.0.16-3 but still getting the Apple M1 build is "damaged". Is there a workaround for M1/arm?

I'm on macOS Big Sur Version 11.5.2 running M1.

ryan6416 avatar Sep 14 '21 23:09 ryan6416

@ryan-efendy we're still waiting on a fix from the linked electron-builder issue - you should be able to run the normal macOS dmg though and let Rosetta do its thing. It's not ideal but at least it's what works at the moment.

dragonwocky avatar Sep 14 '21 23:09 dragonwocky

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Oct 30 '21 02:10 github-actions[bot]

@ryan-efendy we're still waiting on a fix from the linked electron-builder issue - you should be able to run the normal macOS dmg though and let Rosetta do its thing. It's not ideal but at least it's what works at the moment.

It's extremely buggy on the default Rosetta-esque version. Pressing on the Notion-Enhancer icon on the menu bar renders the application to disappear, and it takes a while and multiple tries to get the application back out visually.

For now, I have completely uninstalled the application and am not going to be touching it until the M1 has been successfully patched and back to normal.

ghost avatar Oct 30 '21 04:10 ghost

@Joonkyu tip: you can use the hotkey to re-focus the app when it disappears (Cmd+Shift+A by default, can be changed in the menu).

The enhancer just hasn't received a proper update in too long, so it's not working great at the moment - the bugs are just bugs, none of them are related to whether you use the M1 version or run it through Rosetta. A new version is close to release though.

dragonwocky avatar Oct 30 '21 07:10 dragonwocky

@dragonwocky Do you have any idea on when the next update may be? I may give this another try once the new update comes out, I just prefer to work with performant applications than good concept and poor execution (outdated applications).

ghost avatar Nov 01 '21 15:11 ghost

@Joonkyu i'm maybe 2/3 through overall development. it might be out around Christmas or January sometime (no guarantees though).

dragonwocky avatar Nov 01 '21 23:11 dragonwocky

Please, can anyone confirm if the arm64 DMG build is runnable? As in Mac OS lets you run it even if it's completely broken and doesn't load. This issue refers to a problem we had for a long while where the DMG build was deemed "corrupted" by Mac OS.

jamezrin avatar Dec 12 '21 19:12 jamezrin

deep0d0#9946 over at our Discord confirmed the arm64 Mac build runs without problems on their Mac. You just have to run xattr -cr <path to Notion Enhanced.app> and the app will no longer show as "damaged" or "corrupted"

jamezrin avatar Jan 01 '22 22:01 jamezrin

Maybe this is a good way to get some Mac users over to Linux. :)

brianrobt avatar May 18 '22 08:05 brianrobt

You just have to run xattr -cr <path to Notion Enhanced.app> and the app will no longer show as "damaged" or "corrupted"

Added to the installation instructions here: https://notion-enhancer.github.io/getting-started/installation/#apple-silicon-(m1)-macs

dragonwocky avatar Jun 04 '22 07:06 dragonwocky

Hey, this is still broken for me. I just get the regular notion layout, without any of the enhancer features (not even its menu item in the left pane)

itaiperi avatar Jun 21 '22 12:06 itaiperi

@itaiperi see https://github.com/notion-enhancer/desktop/issues/762

dragonwocky avatar Jun 21 '22 12:06 dragonwocky