notion-repackaged icon indicating copy to clipboard operation
notion-repackaged copied to clipboard

Object.hasOwn is not a function in mermaid diagrams in notion-repackaged

Open dolfandringa opened this issue 1 year ago • 4 comments

What is happening? When looking at a mermaid diagram (rendered through a code snippet of language mermaid) I see the mermaid code, but when its rendering the image, it give a javascript error Unknown Error: TypeError: Object.hasOwn is not a function.

Checking the error, it looks like Object.hasOwn is only supported since nodejs 16.9, but looking in this repo, notion-repackaged seems to use nodejs 14.17.1. This would explain the issue.

If upgrading nodejs isn't an option, there also seems to be a polyfill for it that could maybe solve it? https://github.com/es-shims/Object.hasOwn

What should be happening? The mermaid diagram should be rendered.

Screenshots (if applicable): Issue in notion-repackaged: image

Its fine in the browser: image

Operating system/browser name & version: Fedora Linux 38

notion-enhancer and/or notion-repackaged version: notion-app-2.0.18-1.x86_64

notion-enhancer configuration (enabled/disabled mods and their settings):

dolfandringa avatar Sep 21 '23 15:09 dolfandringa

me too

reopencil avatar Sep 30 '23 06:09 reopencil

Same on Ubuntu 22.04, notion-app

sheiun-xu avatar Oct 26 '23 08:10 sheiun-xu

我也是,在Ubuntu22.04上,notion-app-enhanced

Yu-Xiao-Sheng avatar Jan 31 '24 12:01 Yu-Xiao-Sheng

same :(

iliabaranov avatar Mar 08 '24 18:03 iliabaranov