notifo icon indicating copy to clipboard operation
notifo copied to clipboard

SQL support using YesSQL

Open SebastianStehle opened this issue 4 years ago • 8 comments

SebastianStehle avatar Dec 21 '20 16:12 SebastianStehle

Hello. I can do this. Let me check the project source code out.

faridprogrammer avatar Dec 23 '20 05:12 faridprogrammer

Sure, you are welcome. EF is also an option as it is probably needed for identity

SebastianStehle avatar Dec 23 '20 07:12 SebastianStehle

I have noticed that the project is using the MongoDB scheduling mechanism. By supporting SQL do we need to completely cut the MongoDB from the project? and need to find an alternative solution for the scheduling part? or we can use both MongoDB and SQLServer at the same time?

faridprogrammer avatar Dec 23 '20 09:12 faridprogrammer

The MongoDB scheduler is basically a timer: https://github.com/notifo-io/notifo/blob/main/backend/src/Notifo.Infrastructure/MongoDb/Scheduling/MongoDbScheduler.cs

I can make the timer part reusable, then we only need to rebuild the store part for SQL.

SebastianStehle avatar Dec 23 '20 09:12 SebastianStehle

I have decoupled the timer stuff from MongoDB.

SebastianStehle avatar Dec 23 '20 10:12 SebastianStehle

Thanks.

faridprogrammer avatar Dec 23 '20 10:12 faridprogrammer

Should I remove the MongoDB implementations or keep them?

faridprogrammer avatar Dec 26 '20 12:12 faridprogrammer

No, I need them ;)

SebastianStehle avatar Dec 26 '20 15:12 SebastianStehle