Deep-Photo-Enhancer icon indicating copy to clipboard operation
Deep-Photo-Enhancer copied to clipboard

Code refactor and cleanup

Open apauliuc opened this issue 4 years ago • 11 comments

Great work writing this paper and coming up with this model. Have you managed to refactor and clean up your demo code? I'm trying to run it and cannot figure the errors I get. Thanks

apauliuc avatar Apr 07 '20 11:04 apauliuc

There is a TF2 version here which anyone can help work on

vlordier avatar Apr 07 '20 11:04 vlordier

There is a PyTorch version here which seems promising.

vlordier avatar Apr 11 '20 20:04 vlordier

Great, thank you very much! Will check them

apauliuc avatar Apr 11 '20 21:04 apauliuc

There is a PyTorch version here which seems promising.

Thank you to recommend my code, but the result is not good. Unfortunately, I don't know how to handle it.

Could you give me some help?

mtics avatar Apr 21 '20 09:04 mtics

Yes, we have fixed batchnorm and implemented 2-Way GAN, running tests right now : code is coming :)

vlordier avatar Apr 21 '20 09:04 vlordier

Yes, we have fixed batchnorm and implemented 2-Way GAN, running tests right now : code is coming :)

Thx a lot, it can be really helpful for me!

mtics avatar Apr 21 '20 09:04 mtics

Hi I have the implemented it in pytorch with 2way gan s and it works as expected, I have a big room to improve memory conumption though https://github.com/MrRobot2211/pytorch-deep-photo-enhancer

MrRobot2211 avatar Apr 21 '20 18:04 MrRobot2211

Hi can you please share the files you have for this project. The maintainer @nothinglo is not updating the links and all of them are broken. Thanks @apauliuc

ozgurozkan123 avatar Sep 18 '20 10:09 ozgurozkan123

Hi can you please share the files you have for this project. The maintainer @nothinglo is not updating the links and all of them are broken. Thanks @apauliuc

Hi, you can see our files in https://github.com/mtics/deep-photo-enhancer or https://github.com/MrRobot2211/pytorch-deep-photo-enhancer

mtics avatar Sep 18 '20 11:09 mtics

Hi you can also check my tf2 version...that is basicaly the same that was atored here, but compatible with tf2

MrRobot2211 avatar Sep 18 '20 18:09 MrRobot2211

Hi,

When I run the TF.py in the "[Online_Demo_Models]_Deep-Photo-Enhancer/LPGAN_exp_G3_736" file, I face this error:

Shapes (2, 1, 32, 32, 128) and () are incompatible

in line: netG_test_output1 = model(netG, test_df.input1, False, netG_act_o, is_first=True)

Would you mind helping me with it? Thank you in advance.

Youlenda avatar Jul 11 '21 05:07 Youlenda