obsidian-codemirror-options icon indicating copy to clipboard operation
obsidian-codemirror-options copied to clipboard

[Feature Request] Allow Banners to show on edit mode

Open ocreturner opened this issue 4 years ago • 5 comments

Not sure if possible! but it would be a great feature if you could make the banners plugin work in edit mode!

ocreturner avatar Oct 25 '21 16:10 ocreturner

I looked into this and it's going to be a pain to do. CodeMirror has a lot of layers, some which scroll, and some that don't. There's no great place to put a banner like that, assuming the goal is to span the entire width of the pane. The closest I could come is this:

image

That gap is due to the line gutters which I would have to mess with the z-index of in order to get to go away. Messing with the z-index of codemirror elements is a bad idea so I can't currently figure out a good way to do this.

nothingislost avatar Oct 25 '21 22:10 nothingislost

ah! i believe this was fixed in discord recently with css

ocreturner avatar Oct 26 '21 01:10 ocreturner

yeah, it's still going to be a pain but I can probably hack something together :)

nothingislost avatar Oct 26 '21 01:10 nothingislost

In case you miss it in the Discord chat 2021-10-26 12 06 09

nothingislost avatar Oct 26 '21 19:10 nothingislost

wow!! you did it ! amazing , just like notion!

ocreturner avatar Oct 26 '21 20:10 ocreturner