npm-kraken-api
npm-kraken-api copied to clipboard
nothingisdead
Looking for maintainers
Hi,
I haven't really had time to maintain this library for a while now, and I don't use Kraken anymore so it's difficult for me to test pull requests. I know that it's still used in a lot of projects, so if someone would like to volunteer to maintain it, please let me know!
how much do you pay? JK. I use this library quite a bit. for your consideration, I will volunteer to help maintain it. if you want to chat/cam some time about it, id be happy to meet you and understand your rules/guidelines for doing so.
Thanks!
I just merged a few of the pull requests that didn't look like they required testing. To start with, I would love it if you could look at any of the other open issues or pull requests, specifically:
For #63 I'd rather clone the params object to avoid mutating the params object that was passed in, as suggested:
Better solution would be to not attach the nonce property to the params object passed from userland.
#57 doesn't seem like it would cause issues, but I'm hesitant to merge it without testing.
#54 conflicts now, and I'd rather it be split into separate pull requests, but it would be great to add unit testing.
If you'd like to work on any of those (or others), can you submit a separate pull request?
#49 would be another good one to take a look at. I don't have a strong opinion on got vs needle, but if I were to change it, I'd probably switch to node-fetch since it follows a standard (and it has no dependencies).
Thanks, I will start looking into them, and yes, if i work on them i will supply separate PR.
@nothingisdead Hello. I am just getting going with this project but reaching out in case it is still possible to get involved as a contributor. Could at least get started with #54 as unit tests are a great way to start learning a pre-existing code base.
@lnxslack I have not yet received a reply either. But perhaps you would be interested in involvement in this version....
https://github.com/elio-maggini/kraken-nest
@elio-maggini i'm starting to nodejs, i will need help to follow you on this. May i share some thing i did using kraken-api
Any updates on maintenance? Looks like the hardest part is the no test suite-part :-)
I just made an npm account because I want to publish https://github.com/dscotese/kraken-grid. Anyone with an account there can fork this repo and create a new package on npm but it would be cleaner to follow the process at https://docs.npmjs.com/transferring-a-package-from-a-user-account-to-another-user-account once someone steps up who is willing to be the maintainer. I'm close to doing that, but I worry that there is information I won't be able to get fast enough because I don't know any npm package maintainers. If Robert figures it's easy enough, he can follow those instructions with my username (same as here on Github) and I will do my best.
Sorry for the late answer. What I need to do?
On Fri, Apr 30, 2021, 20:02 Elio Maggini @.***> wrote:
@lnxslack https://github.com/lnxslack I have not yet received a reply either. But perhaps you would be interested in involvement in this version....
https://github.com/elio-maggini/kraken-nest
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nothingisdead/npm-kraken-api/issues/66#issuecomment-830445887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO63W3U3CP3Y2IKXDPWGBXTTLMZHVANCNFSM4KMB4L6A .