notepadqq icon indicating copy to clipboard operation
notepadqq copied to clipboard

[Feature Request] Dark mode for window/chrome

Open lonix1 opened this issue 2 years ago • 14 comments

The dark mode themes are good.

But the "window chrome" itself - frame, buttons, toolbar, statusbar, etc. - are still in light mode. So the overall effect is not really dark mode.

Please consider adding a true dark mode (for the window/chrome items)? Thank you.

lonix1 avatar Sep 17 '22 03:09 lonix1

But the "window chrome" itself - frame, buttons, toolbar, statusbar, etc. - are still in light mode.

That stuff is generally handled by the system theme.

Screenshot from 2022-09-21 22-23-34

Try changing the system theme to a dark theme and see if it's what you expect.

You may also need to change a setting to make QT use the GTK theme. Create and open ~/.config/Trolltech.conf then add [QT] style=GTK+ Save and exit, then reopen the application and see if it changed if not try restarting the shell or even the computer. If it's still light after all that then it would be handy to know what distro and desktop environment your using.

robertapengelly avatar Sep 21 '22 21:09 robertapengelly

I'm using Ubuntu 22.04 with GNOME and this didn't work for me.

I've also tried installing qt5ct with qt5-style-plugins and adding export QT_QPA_PLATFORMTHEME="qt5ct" to ~/.profile but to no avail.

atalantus avatar Jan 30 '23 13:01 atalantus

I'm using Ubuntu 22.04 with GNOME and this didn't work for me.

That's strange as it works for me.

Screenshot from 2023-01-30 13-25-04

Are you running the beta version, flatpak or deb of notepadqq?

robertapengelly avatar Jan 30 '23 13:01 robertapengelly

Also another question I didn't think of originally is are you running the dark theme for the whole distro?

robertapengelly avatar Jan 30 '23 13:01 robertapengelly

I'm running the latest beta version 2.0.0-beta of notepadqq and also GNOME version 42.5. However, I use the X11 Windowing System and not Wayland. Maybe that's the problem.

atalantus avatar Jan 31 '23 14:01 atalantus

Did you install the snap version?

robertapengelly avatar Jan 31 '23 15:01 robertapengelly

deb

atalantus avatar Jan 31 '23 15:01 atalantus

I have no idea why the dark theme isn't working for you then, are you using the dark theme for the distro? I'm not sure how to get the dark theme with the snap package but the deb should be fixed with the previous Trolltech.conf.

robertapengelly avatar Jan 31 '23 15:01 robertapengelly

Yes, I'm using the distros dark theme. I'm currently unable to restart as I'm still running some longer tests but afterward I will try with Wayland and otherwise will try to reinstall notepadqq. I really appreciate you trying to help me though :)

atalantus avatar Jan 31 '23 15:01 atalantus

It's no problem

robertapengelly avatar Jan 31 '23 15:01 robertapengelly

Just realised I missed two environmental values:

echo "QT_QPA_PLATFORMTHEME=gtk2" >> /etc/environment echo "QT_STYLE_OVERRIDE=gtk2" >> /etc/environment

Trolltech:

echo "[QT]" >> ~/.config/Trolltech.conf echo "style=GTK+" >> ~/.config/Trolltech.conf

A restart may be required so once you've done what you need to give it a try. If it's still not dark try the older version:

wget -P /tmp https://launchpad.net/~notepadqq-team/+archive/ubuntu/notepadqq/+files/notepadqq-common_1.4.4-1~xenial1_all.deb wget -P /tmp https://launchpad.net/~notepadqq-team/+archive/ubuntu/notepadqq/+files/notepadqq-gtk_1.4.4-1~xenial1_all.deb wget -P /tmp https://launchpad.net/~notepadqq-team/+archive/ubuntu/notepadqq/+files/notepadqq_1.4.4-1~xenial1_amd64.deb

gdebi -n /tmp/notepadqq-common_1.4.4-1~xenial1_all.deb gdebi -n /tmp/notepadqq_1.4.4-1~xenial1_amd64.deb gdebi -n /tmp/notepadqq-gtk_1.4.4-1~xenial1_all.deb

If you don't have gdebi you can install it using sudo apt install gdebi-core, or you can download and install them an alternative way. If it's still not dark after all that then I'm stumped.

robertapengelly avatar Jan 31 '23 16:01 robertapengelly

Thank you it works now. I guess I was missing the environment variables.

atalantus avatar Feb 01 '23 14:02 atalantus

Hi, I have the same issue where notepadqq is not getting darker with the Ubuntu theme setting. I saw that you can use qt5ct but I am unsure how to use it.

Paru-paru avatar Aug 20 '23 23:08 Paru-paru

@Paru-paru Only the Window gets darker (e.g. title bar, menu and maybe a few other things). The rest of the application gets controlled with the themes in the settings. What issue are you actually facing? Have nothing in this thread helped at all? If not then what version of notepadqq are you using? And what version on Ubuntu are you using?

robertapengelly avatar Aug 24 '23 13:08 robertapengelly