wingup icon indicating copy to clipboard operation
wingup copied to clipboard

Published 20 hours ago • verified publisher icon notepad-plus-plus

Support more sophisticated proxy settings

Open mattesh opened this issue 1 year ago • 1 comments

The commit https://github.com/notepad-plus-plus/wingup/commit/17f2ee0a3f85f48ccad7d5fecc02d4b59f21b262 from gwinkless was giving me the right direction, but was not sufficient for my Kerberos based proxy system. I added required parameters to treat curl as required for different constellations, trying to do as minimal changes to the rest. @donho and @gwinkless could you check from your end if this changes are OK to release? Regards, Mattes

mattesh avatar Feb 19 '24 11:02 mattesh

@donho: What do you think?

Neustradamus avatar Jun 26 '24 20:06 Neustradamus

@donho, Is there anything blocking this to be merged? We did tests and see this as crucial change for new releases of NPP+ Updater Please, let me know if something should be added. Thank you /BR Mattes

mattesh avatar Aug 23 '24 14:08 mattesh

The KISS (Keep it Simple, Stupid) guideline should be respected. However, this PR is complex than it should be, also there are so many stuff added into UI which makes UX difficult. Therrefore the PR is not accepted.

donho avatar Sep 04 '24 04:09 donho