userDefinedLanguages icon indicating copy to clipboard operation
userDefinedLanguages copied to clipboard

SQL_Manifold9_byRKolka: Few edits

Open rkolka opened this issue 3 years ago • 4 comments

Few edits to SQL_Manifold9_byRKolka.xml Added some more samples

rkolka avatar Oct 06 '22 10:10 rkolka

Sorry if I merged the first version too early. Let me know when you're done with modifications, and I'll merge the changes once you're done.

pryrt avatar Oct 06 '22 14:10 pryrt

Oh, wait, there are conflicts. You'll have to fix those before I merge, or create a replacement branch and replacement PR that doesn't have conflicts.

pryrt avatar Oct 06 '22 14:10 pryrt

Thanks. I think it's a good thing that initial version got merged and public. I have received feedback and I have still more tweaks coming in.

Q: For Dark Mode, should this be another file in UDLs directory? Then what aboud autoCompletions? Just identical copy with matching DarkMode filename?

rkolka avatar Oct 07 '22 16:10 rkolka

Yes, use a separate file for the Dark Mode UDL. And since the UDL and autocompletion names must match, use a separate file for that, too.

pryrt avatar Oct 07 '22 16:10 pryrt

If you're still planning on coming back to this, let me know. Otherwise, I am going to reject/close this PR in a day or two.

pryrt avatar Oct 25 '22 19:10 pryrt

You can close it. I hope to revisit this soon, but I can make a fresh PR anytime.

rkolka avatar Oct 26 '22 07:10 rkolka