Turn off selecting text for find dialog

[doug1234]

Added the ability to turn off selecting text when displaying the Field dialog for issue #11988. Now the find dialog text will only be updated if there is a selection.

[alankilborn]

Don't you also have to provide the base localization in english.xml?

[Yaron10]

@doug1234,

That's a useful addition. Thank you for your work.

@alankilborn,

Suggest reversing logic (all these "don't"s make my head hurt when trying to think about what it might do)...

Good point. Thank you.

[vinsworldcom]

Caret is the Scintilla term.

On Thu, Aug 25, 2022, 7:38 PM Doug @.***> wrote:

@.**** commented on this pull request.

In PowerEditor/src/WinControls/Preference/preference.rc https://github.com/notepad-plus-plus/notepad-plus-plus/pull/11989#discussion_r955502216 :

@@ -323,11 +323,12 @@ STYLE DS_SETFONT | DS_FIXEDSYS | DS_CONTROL | WS_CHILD FONT 8, "MS Shell Dlg", 0, 0, 0x1 BEGIN CONTROL "Don't fill find field in Find dialog with selected word", IDC_CHECK_STOPFILLINGFINDFIELD, "Button", BS_AUTOCHECKBOX | WS_TABSTOP,37,10,350,10

• CONTROL "Use Monospaced font in Find dialog (Need to restart Notepad++)",IDC_CHECK_MONOSPACEDFONT_FINDDLG, "Button", BS_AUTOCHECKBOX | WS_TABSTOP,37,25,350,10
• CONTROL "Find dialog remains open after search that outputs to results window",IDC_CHECK_FINDDLG_ALWAYS_VISIBLE, "Button", BS_AUTOCHECKBOX | WS_TABSTOP,37,40,350,10
• CONTROL "Confirm Replace All in All Opened Documents",IDC_CHECK_CONFIRMREPLOPENDOCS, "Button", BS_AUTOCHECKBOX | WS_TABSTOP,37,55,350,10
• CONTROL "Replace: Don't move to the following occurrence", IDC_CHECK_REPLACEANDSTOP, "Button", BS_AUTOCHECKBOX | WS_TABSTOP, 37, 70, 350, 10
• CONTROL "Search Result window: show only one entry per found line", IDC_CHECK_SHOWONCEPERFOUNDLINE, "Button", BS_AUTOCHECKBOX | WS_TABSTOP, 37, 85, 350, 10

• CONTROL "Don't select closest word when Find dialog is displayed", IDC_CHECK_STOPSELECTINGNEARESTWORDONFIND, "Button", BS_AUTOCHECKBOX | WS_TABSTOP, 37, 25, 350, 10

I like the text changes. My only thought is would it better to use "caret" or "cursor"? I can make the changes when everyone is satisfied with the wording unless someone else is going to update the pull request.

— Reply to this email directly, view it on GitHub https://github.com/notepad-plus-plus/notepad-plus-plus/pull/11989#discussion_r955502216, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJVWULGOUQRIK2BCQPL7GTV277ZFANCNFSM55X36GFA . You are receiving this because you were mentioned.Message ID: @.*** com>

[doug1234]

Looks like caret is the winner so I went with that. I am going to spend a bit more time testing and then I will update the pull request.

[doug1234]

OK... I think its ready to go with the suggested changes.

[doug1234]

Should be good now.