notepad-plus-plus icon indicating copy to clipboard operation
notepad-plus-plus copied to clipboard
verified publisher icon notepad-plus-plus

[DarkMode] Not implemented elements in dark mode (WIP)

Open ozone10 opened this issue 4 years ago • 4 comments

image

Dialogs

  • [x] Find and Replace (implemented)
  • [x] FindInFinder (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10233
  • [x] About (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10264
  • [x] DebugInfo (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10264
  • [x] Run (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10251
  • [x] HashFromFiles MD5 (implemeted) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10255
  • [x] HashFromText MD5 (implemeted) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10255
  • [x] HashFromFiles SHA256 (implemeted) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10255
  • [x] HashFromText SHA256 (implemeted) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10255
  • [x] GoToLine (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10245
  • [x] ColumnEditor (implemeted) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10236
  • [x] Style Configurator (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10226
  • [x] Preference (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10264
  • [x] FindCharsInRange (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10247
  • [x] "Mini dialogs" (opening link text/number in preference dialog) (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10253
  • [x] Rename Current Tab (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10249
  • [x] Save all (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10264
  • [x] Color Popup (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10269
  • [x] Shortcut (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10275
  • [x] Run Macro Multiple Times (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10273

More complex

  • [x] PluginsAdmin (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10287
  • [x] Windows (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10230
  • [x] UDL + styler (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10283
  • [x] Shortcut Mapper (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/11530

Other

  • [x] Progress (when searching in files) (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10233
  • [x] Document Switcher (ctrl+TAB) (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10285
  • [x] Close button in other mode (fullscreen, post-it, ...) (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10210
  • [x] Autocomplete and calltip (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/11522
  • [x] Tabbar overflow (updown control) (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10054
  • [x] Edit control border, subclass (implemented)
  • [x] Listbox control border, subclass (implemented)
  • [x] Color dialog, need hooks (implemented) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/12148

Other low priority

Currently I am quite busy and don't have time to do tasks below. Anyone is free to implement it.

  • [ ] Toolbar overflow chevron (from rebar control) https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10103
  • [ ] Menu arrows, subclass https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10202
  • [ ] Message Boxes, need hooks

ozone10 avatar Jul 15 '21 21:07 ozone10

toolbar truncated chevron not visible in dark mode: https://github.com/notepad-plus-plus/notepad-plus-plus/issues/10103

donho avatar Aug 16 '21 00:08 donho

Tabbar overflow (updown control)

image

This one is super bugging me.

ghost avatar Aug 26 '21 10:08 ghost

Tabbar overflow (updown control)

image

This one is super bugging me.

It seems you can call GetTopWindow passing the HWND of the Tab control to get the HWND of the UpDown since it is a child of the Tab control. Or maybe you could monitor WM_PARENTNOTIFY to see when the child UpDown is created/destroyed. Even so, I'm not sure how you'd subclass the UpDown to paint it yourself.

kczx3 avatar Sep 14 '21 09:09 kczx3

WM_PARENTNOTIFY doesn't seem to send for the creation of the UpDown control even though I don't see it having the WS_EX_NOPARENTNOTIFY style.

kczx3 avatar Sep 14 '21 10:09 kczx3