notation icon indicating copy to clipboard operation
notation copied to clipboard

feat: introduce golang ci lint action

Open tungbq opened this issue 1 year ago • 4 comments

Resolves: #718

Background (mentioned in the issue #718 ):

Golang lint is a fast Go linters runner. It runs linters in parallel, uses caching, supports yaml config. It’s used to make sure code adheres to common Go practices. It supports enable many different types of linters.

Changes:

  • Add golangci-lint-action to the CI workflows as it's the official GitHub action for golangci-lint from its authors. The action runs golangci-lint and reports issues from linters.
  • Name the new workflow as golangci-lint in .github/workflows/go-lint.yml
  • Current behaviour:
    • Run golangci-lint on every PR
    • Report only new issue generated from the PR
    • Beside of PR events, there has an option in the trigger event to allow us manually run the workflow if needed (workflow_dispatch:)

Testing:

  • This was tested on my fork repository
  • For example, https://github.com/tungbq/notation/pull/4

tungbq avatar Jun 24 '23 09:06 tungbq