notation icon indicating copy to clipboard operation
notation copied to clipboard

feat: support notation cli end-to-end test framework

Open chloeyin opened this issue 2 years ago • 1 comments

What

Suppor end-to-end test by using Ginkgo Add e2e test infrastructure for notation-cli The core functions are in test/e2e/scenario and test/e2e/internal/utils/exec.go There is a quick introduction in test/e2e/Readme.md

  • Closes https://github.com/notaryproject/roadmap/issues/47

Signed-off-by: zaihaoyin [email protected]

chloeyin avatar Sep 21 '22 08:09 chloeyin

Codecov Report

Merging #343 (54fe598) into main (06b7b5b) will decrease coverage by 0.07%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   30.62%   30.54%   -0.08%     
==========================================
  Files          25       25              
  Lines        1610     1614       +4     
==========================================
  Hits          493      493              
- Misses       1104     1108       +4     
  Partials       13       13              
Impacted Files Coverage Δ
cmd/notation/verify.go 18.62% <0.00%> (-0.38%) :arrow_down:
internal/cmd/signer.go 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 21 '22 09:09 codecov-commenter

@yizha1 - can we just fix the go.mod/sum conflicts and merge and iterate from there?

dtzar avatar Nov 09 '22 23:11 dtzar

@dtzar The test framework needs to be updated based on the ORAS E2E test framework. We may not get it done in rc.1 release @vaninrao10

yizha1 avatar Nov 10 '22 06:11 yizha1

Move to rc.2 since test framework need to be improved based on the practice in ORAS project.

yizha1 avatar Nov 18 '22 14:11 yizha1

Close this PR as we have a new framework based on this PR

chloeyin avatar Jan 04 '23 02:01 chloeyin