test: fix build on 32bit platforms

[siretart]

Reproduce with:

$ GOARCH=386 go test -v github.com/notaryproject/notation-go ./notation_test.go:763:26: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows) FAIL github.com/notaryproject/notation-go [build failed] FAIL

Signed-off-by: Reinhard Tartler [email protected]

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 81.47%. Comparing base (e83edbc) to head (dcf20b7). :warning: Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files          36       36           
  Lines        3358     3358           
=======================================
  Hits         2736     2736           
  Misses        480      480           
  Partials      142      142           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[FeynmanZhou]

@siretart Thanks for adding 32bit arch support. Would you mind sharing your use case? I am curious on your scenario.

[siretart]

I'm packaging this library for Debian, and we test it on like a dozen different architectures.

The use case can be described as having the notation cli binary prebuilt for as many architectures as possible so that it can be made available a regular Debian package and available via apt install notation

[JeyJeyGao]

@siretart Could you sign your commit by follow the guide. Also please rebase the main branch. Thank you!

[github-actions[bot]]

This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

[FeynmanZhou]

@siretart Just to follow up, could you sign your commit by follow the guide and rebase the main branch? Otherwise it will be closed by the GitHub bot. Thanks

[github-actions[bot]]

This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

[siretart]

sorry for the delay.

I've now signed this commit with the gpg key I'm using to sign my packages in Debian. Let me know if that is acceptable

[github-actions[bot]]

This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

[siretart]

anything else missing? I believe this can be cherry-picked

[github-actions[bot]]

This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

[shizhMSFT]

@siretart Could you sign your commits so that we can merge this PR?

[siretart]

As far as I can tell https://patch-diff.githubusercontent.com/raw/notaryproject/notation-go/pull/500.patch already contains a proper "signed-off-by" line.

Maybe you mean something else that I might be missing?

[siretart]

As far as I can tell, the current patch already contains a proper "Signed-off-by" line. Check here:

https://patch-diff.githubusercontent.com/raw/notaryproject/notation-go/pull/500.patch

Maybe I'm missing something else? Please clarify what you mean exactly.

[github-actions[bot]]

This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

[jas4711]

Hi! Could someone cherry-pick and merge this? I can confirm that it solves a i386 build error:

https://salsa.debian.org/jas/golang-github-notaryproject-notation-go/-/jobs/8531986

src/github.com/notaryproject/notation-go/notation_test.go:589:26: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows)

Thanks, Simon

[FeynmanZhou]

@siretart can you please follow the guide to sign it? It looks like your git commit is not signed correctly. The right commit should have this signal

Hi @jas4711 , would you mind opening a new PR with a signed commit if this is required for your scenario? This is a tiny change so it can be merged very quick.

[jas4711]

Hi @jas4711 , would you mind opening a new PR with a signed commit if this is required for your scenario? This is a tiny change so it can be merged very quick.

I pushed #563 now, superseding this merge request -- does it help?

[toddysm]

Closing this as per the comments above and https://github.com/notaryproject/notation-go/pull/563 superseding this one.