notary icon indicating copy to clipboard operation
notary copied to clipboard

Published 20 hours ago • verified publisher icon notaryproject

RFC: use go modules

Open SantiagoTorres opened this issue 5 years ago • 7 comments

I just did this for the sake of avoiding GOPATH insanity and quality of life.

What do you people think?

SantiagoTorres avatar Apr 18 '19 16:04 SantiagoTorres

Can one of the admins verify this patch?

docker-jenkins avatar Apr 18 '19 16:04 docker-jenkins

Happy to change over to Go modules. This needs a rebase.

justincormack avatar Jun 03 '19 14:06 justincormack

@justincormack thanks for reviewing! Sorry for the delay, it's been rather busy lately...

SantiagoTorres avatar Jun 14 '19 16:06 SantiagoTorres

@SantiagoTorres could you update your PR to use Go 1.13 instead? That would also be aligned with another PR #1515 waiting to be merged. If you don't have time, I'm happy to file a replacement PR.

marcofranssen avatar Jan 10 '20 08:01 marcofranssen

Hi, I'll pick this up this weekend. Should be triival enough for me to update but let me take a look...

SantiagoTorres avatar Jan 10 '20 22:01 SantiagoTorres

@marcofranssen I updated this PR. I also had to fix one test(?), but I added it as a separate commit in case we want to discard that for now.

SantiagoTorres avatar Jan 11 '20 23:01 SantiagoTorres

This can probably be closed now that https://github.com/theupdateframework/notary/pull/1523 did this

thaJeztah avatar Mar 12 '21 13:03 thaJeztah