Adding `/usr/bin/env bash`

[truongnh1992]

This commit aims to add /usr/bin/env bash as a shebang line to indicates scripts use bash shell for interpreting.

Signed-off-by: Nguyen Hai Truong [email protected]

[docker-jenkins]

Can one of the admins verify this patch?

[justincormack]

I would rather we could just use /bin/sh to be honest. Is there anything non Posix in those files?

[truongnh1992]

I would rather we could just use /bin/sh to be honest. Is there anything non Posix in those files?

It uses bash instead of sh shell.

[justincormack]

I know it uses bash now, but does it need to? Does it use any bash-only features?

[marcofranssen]

/usr/bin/env sh or /usr/bin/env bash is the recommended best practice when writing bash scripts.

https://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my

If we don't use bash specific functions sh is preferred as well. Imagine developers having zsh and no bash. Then it still works without installing bash.