Artom Lifshitz

The change from the PR is on the server. @twinkietoes-on does it make sense? I'm basically just skipping any file that mp3gain cannot process for whatever reason.

Alright, I think the commit above (7f63d1c) should prevent broken files form reaching the validator. Is that the only problem though? What about the filenames with the period at the...

https://github.com/LibriVox/librivox-catalog/pull/213 is the correct "industry standard" way to do these things. If that passes the checks, I'll merge it, then propose a patch to librivox-ansible to run the DB migrate...

OK, @peterjdann you should be good to create our first migration under `application/migrations`, see https://codeigniter.com/userguide3/libraries/migration.html#create-a-migration for an example. That should not only make our CI pass, but also create a...

Playing with this PR locally, I kept getting this error: ``` The migration class "Migration_Add_keywords_instances_field" is missing an "up" method. ``` Looks like there's a bug with CodeIgniter itself: https://stackoverflow.com/questions/65405139/no-working-up-method-in-migrate-codeigniter-3-with-php8...

This is a really big PR (naturally), so reviewing it as a whole is difficult. In cases like this, I normally fall back on reviewing one commit at a time...

That's pretty spot on - `git` has various commands that can help, so let me know if you need pointers.

Yep, very much what @redrun45 said. Looking at the code in the PR again, honestly _nothing_ jumps out as being super easy to write a unit test for. Anything that...

Let's re-open this to remind ourselves that there are still 2 spots where SELECT DISTINCT is in use.

> This is what is causing names to show up on the Archive description more than once, when the reader has more than one section, correct? It would be nice...