Andy Valdez

Results 31 comments of Andy Valdez

> I noticed that iOS has some buttons for similar features on its Debug settings screen. We can do the same. I'll need some time to look into how iOS...

@irfano sorry I didn't get to this sooner. Mind taking a look when you get a chance and give me your thoughts. I did what was mentioned. Add a new...

> @notandyvee, while reviewing the change, I noticed a screen that already contains your new pref, pref_always_show_announcement. This screen was introduced 4 months ago (https://github.com/wordpress-mobile/WordPress-Android/pull/19880). Do you think we can...

@justtwago I made some edits to `DebugSharedPreferenceFlagsViewModel` that require your approval. I needed a debug shared pref value for debugging. Since the shared pref needs to be written first before...

@irfano I'll fix the failing test. > What does "Class used to track" mean? I started to add class doc and stopped mid way 😅 . Updated now. > Now,...

@irfano need some more information here. Do stats not work on XML-RPC API? Is the json API required?

@thomashorta ready for re-review 🙏🏻

@thomashorta I responded to your bigger point. But I made slightly bigger changes in response. As it turns out, I didn't even need to mock anything 🤦🏻 . Since we...

TL;DR: Read the source :P Although I know this is old I figure it's good to have a record of how to solve this. You can use `FloatingActionButton#setIconDrawable` programmatically. Simply...

Code LGTM and everything works great. But one thing I noticed. Two cards have the same title, which is less than ideal. I recommend making it clearer. "Subscribers Chart", "Subscribers...