midi_patchbay
midi_patchbay copied to clipboard
notahat
modernization update
This PR a general modernization update for building the app for macOS 10.10+ as well as 64 bit builds for 10.15+.
In also integrates existing PRs #1 and #2 as well as a commit from one of the forks. I also took the liberty of updating the (meta) documentation to markdown.
I find this application extremely useful and would very much like to see an official release of this proposed 1.0.4 version as a 64 bit build. It's obvious the design is solid and the CoreMIDI API is stable as MIDI Patchbay has worked just fine over the last 10 years. Hopefully this afternoon of work will ensure that it does for the next 10. :)
EDIT: 64 bit version 1.04 test builds are here: http://docs.danomatika.com/releases/midipatchbay/
NOTE: For attribution, I should probably listed as "Dan Wilcox (ZKM | Hertz-lab)" to include the fact this work was done within my normal job.
@danomatika You're a champion! I'll try to have a look this weekend and get an official release out. I'll add you to the credits and give you a mention on the website too.
Thanks. It's mainly a community effort I pulled together: see the attribution in the proposed 1.0.4 version at the end of the readme.
There are still two points which are in question:
- I noticed the UI in the repo is slightly different from the last release (1.0.3). I find the release version to be a better layout, but I wasn't sure enough about the design decisions involved to change it directly.
- placement of the Input & Outputs
- placement of Add Patch button and additional Remove Patch button
- 1.0.3 opens with Notes tab selected by default instead of Channels tab
In the repo:
Version 1.0.3:
- There is still a deprecation warning for the custom TableView Enter key handling which was non-trivial to change.
I will make proposed implications for both of these issues in feature branches and post back.
Recent work:
- UI updates are in a separate branch: #5.
- The custom table view enter key handling does not appear to be needed any longer as the selection remains after an edit is finished. It is commented out for now which solves the deprecation warning.
- ARC transition is done: mainly removing retains/releases and setting __bridge casts.
- I noticed that endpoint switching was not saved after leaving the endpoint panel and the logic was commented out. This has been re-enabled with a check to make sure selecting the same endpoint does not add an undo action.
- There are now two build schemes: Debug and Release
EDIT: That should it for now. I think everything is covered, unless bugs or more inconsistencies with the 1.0.3 release version are found.
Oh, and ARC modernization is needed as well.
Yeah, I'm going through the changes, and I'm suspicious of all the memory management stuff. The fun is that CoreMIDI doesn't correctly follow Apple's own memory management rules, so I'm not sure how it's gonna interact with ARC. Gonna have to do some more reading and testing.
I am happy to continue testing as needed. The current version (RC2 I guess it'd be called?) seems to run fine, and I didnt see any noticeable performance issues in terms of memory/CPU usage, although I also wasnt looking for such things.
It’s all in a single commit, so it should be straightforward to review. I have a couple projects using CoreMIDI so I know what you mean. Most of what I did was to add bridging casts for strings and you were already deep-copying those coming from and owned by CoreMIDI, as far as I can tell. I can double check as well.
enohp ym morf tnes
Dan Wilcox danomatika.com robotcowboy.com
On Dec 8, 2019, at 12:14 AM, Pete Yandell [email protected] wrote:
Oh, and ARC modernization is needed as well.
Yeah, I'm going through the changes, and I'm suspicious of all the memory management stuff. The fun is that CoreMIDI doesn't correctly follow Apple's own memory management rules, so I'm not sure how it's gonna interact with ARC. Gonna have to do some more reading and testing.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
@notahat I'm happy about #6. This PR is definitely more quick triage as I went quickly without a deep understanding of the code. If it's helpful in the end, great.
@danomatika - so glad you did this. I too was slowing trying to bring this up to date and super glad to see the activity here. I did some quick testing on the test build and it seems to work well on 10.15.2. Happy to continue testing as needed until merged.
