Stock-Trading-Environment icon indicating copy to clipboard operation
Stock-Trading-Environment copied to clipboard

action_type claimed to be discrete but is a BOX

Open ppanteliadis opened this issue 5 years ago • 1 comments

If you are claiming a Discrete action space, I would expect something like

if action_type == 1: #BUY
elif action_type ==2: #SELL
else: # HOLD

Why the action_type is a float? I'm new in to gym environments. so maybe this is more of a question https://github.com/notadamking/Stock-Trading-Environment/blob/e72167bb4e134fc998f11c2f9d14ae9d882431ce/env/StockTradingEnv.py#L70

ppanteliadis avatar Jan 10 '20 10:01 ppanteliadis

If you are claiming a Discrete action space, I would expect something like

if action_type == 1: #BUY
elif action_type ==2: #SELL
else: # HOLD

Why the action_type is a float? I'm new in to gym environments. so maybe this is more of a question

https://github.com/notadamking/Stock-Trading-Environment/blob/e72167bb4e134fc998f11c2f9d14ae9d882431ce/env/StockTradingEnv.py#L70

如果您要声明一个离散动作空间,我会期望类似

if action_type == 1: #BUY
elif action_type ==2: #SELL
else: # HOLD

为什么 action_type 是浮点数?我是健身房环境的新手。所以也许这更像是一个问题

https://github.com/notadamking/Stock-Trading-Environment/blob/e72167bb4e134fc998f11c2f9d14ae9d882431ce/env/StockTradingEnv.py#L70 action_type == 0:#BUY action_type == 1:#SELL action_type == 2:#HOLD

596227421 avatar Apr 27 '22 09:04 596227421