RLTrader icon indicating copy to clipboard operation
RLTrader copied to clipboard

Performance

Open jsztompka opened this issue 5 years ago • 2 comments

jsztompka avatar Jul 09 '19 19:07 jsztompka

While I have not confirmed if this actually improves speed (i have a hunch it does), I have tested this PR with the latest codebase and can confirm it works.

rshtirmer avatar Jul 10 '19 17:07 rshtirmer

It's fairly easy to test, if you use MlpPolicy on the agent (it's just a bit faster and more visual) , what I've noticed is that after about 2-3 minutes of running optimization the whole thing really slows down. If you look at the code in the _next_observation it keeps adding new observations to the frame and does all recalculations on the full frame so as the list grows it becomes slower.

jsztompka avatar Jul 11 '19 08:07 jsztompka