notV4l

for starknet_trace_api : - add ADDRESS def to components/schema ``` "ADDRESS": { "$ref": "./api/starknet_api_openrpc.json#/components/schemas/ADDRESS" } ``` - yarn gen_trace_api --> infinite loop :(

> > _[Reviewable](https://reviewable.io/reviews/starkware-libs/starknet-specs/88)_ status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @notV4l) > > _[`api/starknet_write_api.json` line 145 at r1](https://reviewable.io/reviews/starkware-libs/starknet-specs/88#-NVZ4cUAA3619fHu0fgt:-NVZ4cUAA3619fHu0fgu:b-plspii) ([raw file](https://github.com/starkware-libs/starknet-specs/blob/443c47f4e75d0a1cf480729bb65aa9071c8439e1/api/starknet_write_api.json#L145)):_ > > > ```json > >...

using "old" syntax : ``` #[event] fn ComplexEvent(event_info: EventInfo) {} ``` contract compiles, but EventInfo type is not generated (tested with 2.0.0-rc3)

I don't feel able to make modifs to make it work the way @mkaput described. I could make a PR to fit @orizi requested changes (just let me know) but...

> Good point. One improvement we could is to output the ipfs metadata uris into the manifest files. So unless it changes, we don't upload to ipfs. Another thing we...

> > this should work with next scarb version and be way cheaper > > > > > > closes #1859 > > > > When you say next version,...

not able to reproduce with latest version 0.7.2

> i cant reproduce this issue. i dont think its associated with #1688 as the PR hasn't been merged yet yes glihm noticed me it's not merged yet, i had...