nanoserde icon indicating copy to clipboard operation
nanoserde copied to clipboard

error in core changes

Open knickish opened this issue 1 year ago • 1 comments

Now that error in core is stabilizing, look at simplifying the feature flags (and making them additive). CI will fail here until it finishes stabilizing, but if we wait for this feature to land it should let us simplify a lot of the code, and only gate features that really rely on std (such as hashmaps) behind a std feature flag

knickish avatar Jun 09 '24 17:06 knickish

Looks like this made it in to the 1.81 milestone, so hopefully can merge this after 2024-09-05 when 1.81 is released

knickish avatar Jul 16 '24 22:07 knickish

There are a lot of changes on master that are not on a crates-io release, might make sense to just merge this and leave the nightly requirement for now

knickish avatar Jul 25 '24 11:07 knickish

@not-fl3 Any thoughts on doing this? Can swap the no_std flag for a std flag and make it a purely additive feature. Will require nightly to use without the std feature until 1.81 releases, but we currently require nightly for no std anyway. After that rust version releases, the nightly requirement can be dropped without a breaking change

knickish avatar Jul 25 '24 11:07 knickish

As long as std is on by default, nanoserde = * is the only thing required and we don't bump the minimal rust version for a std use case - I am fine with any no_std change, I do not have any strong opinions here

not-fl3 avatar Jul 25 '24 15:07 not-fl3