macroquad icon indicating copy to clipboard operation
macroquad copied to clipboard

Touch simulation additions

Open juli5n opened this issue 2 years ago • 5 comments

juli5n avatar Mar 08 '23 19:03 juli5n

Is it bad practice, that this PR still has the original Window2d struct commit in it (and a revert commit) that is not related to this PR? Would you have suggested using git-cherry-pick for distributing the changes of my branch to two branches or something else @not-fl3?

juli5n avatar Mar 08 '23 19:03 juli5n

I just saw a much better way to embed this functionality into the codebase, I will correct it tomorrow.

juli5n avatar Mar 08 '23 20:03 juli5n

Is it bad practice, that this PR still has the original Window2d struct commit in it (and a revert commit) that is not related to this PR? Would you have suggested using git-cherry-pick for distributing the changes of my branch to two branches or something else @not-fl3?

generally each PR should have just the commits related to this PR, usually before making the PR you want to rebase your feature branch from the origin's main branch

not-fl3 avatar Mar 08 '23 23:03 not-fl3

I would like to add functionality for simulating artificial input events through function calls as well. @not-fl3 Do you think that it is a good idea to save a pointer to the stage given to miniquad in the Window::from_config method in the context so that methods in macroquad can use the pointer to the Stage struct to issue input events? (1) Since the Stage struct has no data right now and basically acts like a module for functions (is there any reason for that? I do not understand why the code is written that way right now), I could alternatively just create another Stage instance in the methods that should raise input events. Is that a better idea? (2) I could also just let the methods access the context directly, but this would require more code, especially if we would like InputReceivers to receive the artificially created input as well. (3)

juli5n avatar Mar 09 '23 13:03 juli5n

I am not sure if I have the time right now to do the former though.

juli5n avatar Mar 09 '23 14:03 juli5n