NES.css
NES.css copied to clipboard
feat(icon): Add about.me icon
Description This is a icon about https://about.me
Icon idea is from https://about.me/favicon.ico
It only shows "me" as tab icon in firefox.
Compatibility It seems fine with compatibility.
Caveats important: after merging, update document, please. I should also add this icon to update the document, but i did not add it. Because I found that document use the following css file, if I add icon to document, it would break document. https://unpkg.com/nes.css@latest/css/nes.min.css
sorry for again and again force push.... only to change commit message to fit commitlint. I have changed commit message for several times, but it still cannot pass commitlint test.... But it seems work fine in my local environment. This is my first time to use commitlint, I cannot figure out how to solve it.
I read #413 and #415, understood situation.....
Don’t worry @candywater, this is actually an issue with our CI, not your PR. We’re investigating the issue in #415.
As much as I would like this icon, I don't have authorization to merge any new icons. References:
- https://github.com/nostalgic-css/NES.css/pull/410#issuecomment-601461677
- https://github.com/nostalgic-css/NES.css/issues/310#issuecomment-469073437
So we will need to wait for the creator in this one. I will make a new PR to all README.md regarding this. I do apologize for the delay.
Thanks for your mention! @guastallaigor
I have read #310 , too.
I understood the situation, maybe NES-icons.css is a much better idea.
and here are the images