roundcube-yubikey-plugin icon indicating copy to clipboard operation
roundcube-yubikey-plugin copied to clipboard
verified publisher icon northox

RC 1.3.8: multiple issues

Open corbolais opened this issue 6 years ago • 2 comments

Hi and thank you for the plugin.

Have been trying w/ RC 1.3.8, works OK-ish. So far so good.

However,

  • on every login-related page, the yubikey form is displayed. If using i.e. with twofactor_gauthenticator, the yubikey form is again displayed.
  • form field is named "roundcube_yubikey_plugin".
  • it would be quite nice to have some documentation or at least hints on how to avoid yubikeys API servers.

Cheers!

corbolais avatar Mar 08 '19 14:03 corbolais

I guess your latest pull request fixes the 2nd issue but not the other two. Can you clarify?

As for the last one, I believe it would be better to point people to Yubico’s documentation and the lines used to specify the servers URL (i.e. https://github.com/northox/roundcube-yubikey-plugin/blob/master/lib/Yubico.php#L160-L164). Or a pull request could move this list of URL to the user specified configuration (config.inc.php).

northox avatar Mar 14 '19 18:03 northox

Your assumption is correct, this PR fixes above issue No2.

I would handle above issue No1 together with repo issue #23, as it seems to fall into a similar category of restructuring that part of the code.

Or a pull request could move this list of URL to the user specified configuration (config.inc.php). This would be my personal favourite. Together with a reference/link to Y's docs and a local how to of sorts.

cheers

corbolais avatar Mar 16 '19 18:03 corbolais