nanoeth icon indicating copy to clipboard operation
nanoeth copied to clipboard

Add transaction tests

Open norswap opened this issue 3 years ago • 0 comments

There are a few things that should be added to transaction tests, for completeness' sake:

  • testing chain IDs of 0 and very high chain IDs
  • testing EIP-2930 transactions (access lists)
  • testing EIP-1559 transaction (base fee + miner tip separation)

"Transaction tests" are tests that focus on validating the format of transactions (i.e. they are not run against any state).

The last two items above are at least partially tested in the block tests (whose purpose is to validate blocks and test transitions), but it would be cleaner to have separate transaction-level tests.

You probably want to add entries to OwnTransactionData

This could also be an upstream contribution to https://github.com/ethereum/tests (note that you will need to generate the transactions by first making a "filler file" and using an existing client (probably geth?) to generate the actual test file).

The methods in DebugUtils might be useful.

As always, feel free to contact me for more info.

norswap avatar Sep 29 '21 22:09 norswap