Jeremy Rose

Results 307 comments of Jeremy Rose

ah, ok! makes sense, thanks for the note :)

Belatedly, this is fixed now!

Could we use a [FinalizationRegistry](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry) to watch for GC? Or hook the destructor on the C++ side?

Odd, what browser / OS versions are you using? Have you tried Ctrl+Shift+R or otherwise clearing the app data?

Reopening as this seems like probably a real bug!

As a data point, I just spawned a FEMA camp in debug mode and stripped all the ammo. I found 120 x 5.56 NATO M855A1, which is quite a bit...

hm, it looks like currently in the data, armor_acidchitin doesn't have a proportional encumbrance specified: https://github.com/CleverRaven/Cataclysm-DDA/blob/cdda-experimental-2024-09-22-0113/data/json/items/armor/suits_protection.json#L78-L89 but i can definitely believe the Guide doesn't interpret this correctly!

[boots_western](https://cdda-guide.nornagon.net/item/boots_western) has proportional encumbrance of 2 over [boots](https://cdda-guide.nornagon.net/item/boots): https://github.com/CleverRaven/Cataclysm-DDA/blob/03763473c2ae6d4e559306c74099890d306a8211/data/json/items/armor/boots.json#L991 but they display the same encumbrance in the Guide, so that'll be easier to test this bug.

Thanks for reporting this and helping to make Electron better! Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue?...

Gist version for easy fiddling: https://gist.github.com/02633b74476823a9b77d92700c4b00f9 I can also repro this on mac: ![image](https://user-images.githubusercontent.com/172800/111232388-43988100-85a8-11eb-9361-1e06b13a5002.png)