atom icon indicating copy to clipboard operation
atom copied to clipboard

Separate audio from atom nucleus

Open dcollien opened this issue 11 years ago • 5 comments

What do you think of separating the audio from the core of atom as a plugin? Something like this.

dcollien avatar Aug 21 '13 09:08 dcollien

What justifies making it harder to copy-paste everything?

nornagon avatar Aug 21 '13 15:08 nornagon

maybe its not in line with your goals:

most stuff I do with atom doesn't require the audio stuff, just the core, so that's the bit I copy/paste, and then include the audio bit when/if I need it... (but i tend to use different packages for audio)

so it actually helps in that respect (don't have to think about what I do/don't need, just copy the core, then shove in other things as needed)

its also keeping with the "does as little as possible" theme, while having some ability to branch out and add other extensions/plugins when wanted

eg In a current project I have a set of graphics helpers that extends atom, and an extension that does dirty flagging to make it more suitable for apps where not much happens between interactions

On Thursday, August 22, 2013, Jeremy Apthorp wrote:

What justifies making it harder to copy-paste everything?

— Reply to this email directly or view it on GitHubhttps://github.com/nornagon/atom/pull/8#issuecomment-23023715 .

dcollien avatar Aug 21 '13 18:08 dcollien

You don't have to use the audio bits at all :) I find them handy to have in core because I can use the code for html5 audio api reference, even if I end up tearing it out and using something else.

An annoying thing about leaving it out is that if i just copy the core, then later want to use audio, i have to go find the audio bits. If it's just in atom.coffee, I can just use it.

Theoretically, I like the idea of having it be separated into pieces, but I think that's not quite in line with the scrappy nature of atom. Just fork and cut out the audio bits yourself (or slice them out every time you paste). There's no reason you have to paste the atom.coffee from the repo, just paste your edited one from $LAST_PROJECT

nornagon avatar Aug 21 '13 18:08 nornagon

sounds like a plan,

it's small enough I could keep things in sync by hand anyway (for atom upgrades)

also, there's some AudioContext (eg Mozilla) compat stuff in there too that i was playing with and might also be useful to merge at some stage

On Thursday, August 22, 2013, Jeremy Apthorp wrote:

You don't have to use the audio bits at all :) I find them handy to have in core because I can use the code for html5 audio api reference, even if I end up tearing it out and using something else.

An annoying thing about leaving it out is that if i just copy the core, then later want to use audio, i have to go find the audio bits. If it's just in atom.coffee, I can just use it.

Theoretically, I like the idea of having it be separated into pieces, but I think that's not quite in line with the scrappy nature of atom. Just fork and cut out the audio bits yourself (or slice them out every time you paste). There's no reason you have to paste the atom.coffee from the repo, just paste your edited one from $LAST_PROJECT

— Reply to this email directly or view it on GitHubhttps://github.com/nornagon/atom/pull/8#issuecomment-23040531 .

dcollien avatar Aug 21 '13 19:08 dcollien

yeah for sure, i think i just put a '# TODO firefox' in there :P

j

On Wed, Aug 21, 2013 at 12:06 PM, David Collien [email protected]:

sounds like a plan,

it's small enough I could keep things in sync by hand anyway (for atom upgrades)

also, there's some AudioContext (eg Mozilla) compat stuff in there too that i was playing with and might also be useful to merge at some stage

On Thursday, August 22, 2013, Jeremy Apthorp wrote:

You don't have to use the audio bits at all :) I find them handy to have in core because I can use the code for html5 audio api reference, even if I end up tearing it out and using something else.

An annoying thing about leaving it out is that if i just copy the core, then later want to use audio, i have to go find the audio bits. If it's just in atom.coffee, I can just use it.

Theoretically, I like the idea of having it be separated into pieces, but I think that's not quite in line with the scrappy nature of atom. Just fork and cut out the audio bits yourself (or slice them out every time you paste). There's no reason you have to paste the atom.coffee from the repo, just paste your edited one from $LAST_PROJECT

— Reply to this email directly or view it on GitHub< https://github.com/nornagon/atom/pull/8#issuecomment-23040531> .

— Reply to this email directly or view it on GitHubhttps://github.com/nornagon/atom/pull/8#issuecomment-23041731 .

nornagon avatar Aug 21 '13 19:08 nornagon