gaiku icon indicating copy to clipboard operation
gaiku copied to clipboard

Add Chunking

Open QuantumEntangledAndy opened this issue 4 years ago • 7 comments

This PR adds some chunking functionality

  • Chunks
    • Generic traits for chunking
    • Flat chunker (name suggestions are OK)
      • This chunk just splits the data into chunks of specified size
    • LOD chunker
      • This chunker uses an octree to make chunks of succesive of higher LOD details
  • Interpolation (used in the LOD chunker)
    • Generic traits for interpolation
    • Nearest neighbor interpolation
    • Trilinear interpolation
  • Example of LOD chunker added to amethyst

https://user-images.githubusercontent.com/13386481/126275921-1504121c-9ad4-4088-81e5-9cf229ca9e50.mp4

QuantumEntangledAndy avatar Jul 20 '21 06:07 QuantumEntangledAndy

That's a pretty cool approach, I like the idea.

norman784 avatar Jul 20 '21 07:07 norman784

It's one of the techniques we discussed in #46 based on that in the Volume GFX blog.

This is just a basic implementation. The full implementation also uses marching squares to join the chunks of different resolutions and get rid of the holes.

QuantumEntangledAndy avatar Jul 20 '21 07:07 QuantumEntangledAndy

I believe that all tests are now passing and that it is ready for review.

I wasn't aware that the doc examples would be compiled and tested like that. It's rather neat, maybe I can add more documentation.

QuantumEntangledAndy avatar Jul 21 '21 13:07 QuantumEntangledAndy

Definitely we should add some documentation, I would suggest to document what you think is harder to understand without some short explanation (and example if is needed) because at this stage it is most likely that things will change and maintain the docs up to date with fast changing code is sometimes difficult.

norman784 avatar Jul 21 '21 13:07 norman784

Ok then :). I think I have this new code already fairly well documented and once this is merged I'll maybe open another PR with doc on my other code too

QuantumEntangledAndy avatar Jul 22 '21 09:07 QuantumEntangledAndy

Cool, let me know when the PR is ready to review.

norman784 avatar Jul 22 '21 09:07 norman784

This PR? I think its fine to review now

QuantumEntangledAndy avatar Jul 22 '21 09:07 QuantumEntangledAndy