action-swiftlint icon indicating copy to clipboard operation
action-swiftlint copied to clipboard

fix: Mark github workspace as safe

Open hellodw opened this issue 2 years ago • 3 comments

Hello @norio-nomura First of all thanks a lot for your work!

Fixed bug for issue #43 Check it out and have a nice day!

hellodw avatar Aug 21 '23 07:08 hellodw

As this PR is not being merged. Here is a fork with this fix: https://github.com/yannpom/action-swiftlint

Working great with this GH Action: .github/workflows/swiftlint.yml

name: SwiftLint

on:
  pull_request:
    paths:
      - '.github/workflows/swiftlint.yml'
      - '.swiftlint.yml'
      - '**/*.swift'

jobs:
  SwiftLint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0  # Fetches all history for all branches and tags
      Enable this Step in the next PR
      - name: GitHub Action for SwiftLint (Strict on files changed in the PR)
        uses: yannpom/action-swiftlint@v1
        env:
          DIFF_BASE: ${{ github.base_ref }}
        with:
          args: --strict

yannpom avatar Nov 14 '23 14:11 yannpom

As this PR is not being merged. Here is a fork with this fix: https://github.com/yannpom/action-swiftlint

Working great with this GH Action: .github/workflows/swiftlint.yml

name: SwiftLint

on:
  pull_request:
    paths:
      - '.github/workflows/swiftlint.yml'
      - '.swiftlint.yml'
      - '**/*.swift'

jobs:
  SwiftLint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0  # Fetches all history for all branches and tags
      Enable this Step in the next PR
      - name: GitHub Action for SwiftLint (Strict on files changed in the PR)
        uses: yannpom/action-swiftlint@v1
        env:
          DIFF_BASE: ${{ github.base_ref }}
        with:
          args: --strict

Were you able to use this with a specific filepath for a custom stylelint file?

joshgordon1 avatar Dec 01 '23 20:12 joshgordon1

Thanks @hellodw and @yannpom for your help, but even using the action forked by @yannpom in my case the step didn't comment those modified files in my PR, instead it did comment others that aren't part of the committed changes. I ran the linter locally just to make sure there isn't error with the config.

cerezo074 avatar Jun 13 '24 22:06 cerezo074