Norihiro Kamae

Results 190 comments of Norihiro Kamae

If a plugin does not have confit_set_default..., 0 is assumed as the default. However this PR only changes config_set_default... APIs so that the assumed 0 won't be written.

> There is a bug in the language setting on first launch. Tried in portable mode. The commit c99256cf2 should fix the issue.

Frame duration comes from 1024 samples for each frame; 1024 / 48kHz = 21.3 ms or 1024 / 44.1kHz = 23.2 ms. Did you intentionally put the magic number `1024...

> It possible this is too short for 44.1kHz Ill test and see maybe we need to be more conservative. Instead of having a hard coded constant, cann't we use...

> We can instead query every encoder and pick the largest period if we are ok with a larger change. I misunderstood the motivation of this PR. Sounds like current...

Previously I fixed audio-only output using `ffmpeg-output`. - https://github.com/obsproject/obs-studio/pull/5418 The output `ffmpeg-output` receives video frames because a flag `OBS_OUTPUT_VIDEO` is set and a callback `raw_video` is defined. The video frames...

Just rebased to the latest master branch.

> It's about two times as fast. 3.687 seconds for 4 GiB of RGBA data compared to the previous 7.677 seconds. How this was tested? Do you have a code...

I compared another proposal from rcdrone on Discord. ```c static inline void gs_premultiply_xyza_rcdrone(uint8_t *data) { uint32_t a = data[3] * 2; data[0] = (data[0] * a + 255) / 510;...

> What's the advantage of this implementation? The point is that `127/255` is smaller than 0.5 but `255 / 510` equals 0.5.