Ligatures are broken on Shell Script filetype

[daenney]

• VSCode Version: 1.41.1
• Nord plugin version: 0.13.0
• OS Version: Linux monoceros 5.4.8-arch1-1

Steps to Reproduce:

1. Use a font like Fira Code or JetBrains Mono that supports ligatures: "editor.fontFamily": "JetBrains Mono"
2. Enable ligatures in the editor: "editor.fontLigatures": true
3. Open up a file who's type gets mapped to/detected as Shell Script
4. Try a sequence of characters that should render as a ligature, like != which should render as ≠

When I disable the Nord extension, the issue goes away and ligatures render properly. The issue also goes away if I change the file type to plain, which seems to disable Nord's syntax highlighting entirely.

This doesn't affect all file types, for example ligatures are rendered correctly when editing .go files.

[arcticicestudio]

Hi @daenney :wave:, thanks for your contribution :+1: This sounds a like a strange behavior. Nord doesn't define any specific styles for shell scripts. There is also no way for themes to modify, set or recommend a specific font family to be used with the theme.

I tried to reproduce the problem, but it works fine at least on macOS, but this shouldn't affect the rendering in VS Code in any way. I've used Fira Code instead of the new JetBrains Mono font, so maybe it's a problem with the don't family itself or the package for Arch is not properly created.

With disabled ligatures using Fira Code font

With enabled ligatures using Fira Code font

Can you please try if the problem is still reproducible with other themes like a builtin theme or custom one?

[arcticicestudio]

@daenney Have you been able to fix the problem or reproduce it with other themes?

[daenney]

I can reproduce it on some themes:

• Light, Light+, Dark, Dark+, Kimbie Dark, ligatures work as expected in shell files
• Quiet Light, Solarized Light, Abyss, Monokai, Monokai Dimmed, Red, Solarized Dark, Tomorrow Night Blue, High Contrast: ligatures don't work in shell files

The VS Code built-in themes all work as expected, but a lot of custom themes do not.

[arcticicestudio]

Thanks for testing, so this definitely sounds like a bug in VSCode itself. Could you please open an issue in their repository so they can check this? Feel free to reference this issue, I guess it might help to reproduce the problem.

[svengreb]

Thank you for your patience! 🙏🏼 It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the central and single-source-of-truth project board ^1 that is also described in more detail in the roadmap announcement.

---

@daenney Thanks again for your contributions 🚀 Since the bug was fixed upstream I‘ll close this issue as resolved.