Fix some color issues on source control

[GabrielRMuller]

Description

Hi, I've noticed today while making a commit using VSCode's source control that the options for each file are almost impossible to see when the file is selected, here's an example:

Here's how it looks when the file is just hovered above

I think that one way of fixing this is by changing the options color to match filename color. I can work on it if you guys are cool with it. 😄

Benefits

Improve legibility on source control

[arcticicestudio]

Related to #146

Hi @GabrielRMuller :wave:, thanks for your contribution :+1:

I guess this is related to #146, but unfortunately there's currently no official way to customize VS Code's icons. You can follow the instructions I've posted in https://github.com/arcticicestudio/nord-visual-studio-code/issues/146#issuecomment-509182795 to override the builtin icon styles, but I can also remember to saw a proposal to add theme keys that allows to change the icon color so extensions can customize them to match their style. What's missing here is a feature in VS Code itself to calculate the contrast of the background color for a component and adjust the icon color based on it to get the best contrast.

I guess you've modified the color of the currently selected item in tree view widgets (your second screenshot) to improve the contrast, but doing so will break many other elements and styles like distinguishing active, inactive and unselected tree items, keyboard navigation (accessibility) as well as highlighting for the quick filter feature. Please let me know if the instructions posted in https://github.com/arcticicestudio/nord-visual-studio-code/issues/146#issuecomment-509182795 are a way to solve your problem, otherwise we need to wait for a new VS Code version that provides new theme keys for icon colors.

[arcticicestudio]

@GabrielRMuller It looks like the next version will include new workbench theme keys to customize icons based on their refactoring to extract all icons into a custom icon font.

• icon.foreground
• editorLightBulbForeground and editorLightBulbAutoFixForeground
• notificationsErrorIcon.foreground, notificationsWarningIcon.foreground and notificationsInfoIcon.foreground

I'll track the changes and check the changelogs to add support to Nord for it.

[fspoettel]

I think this can now be fixed via:

 "workbench.colorCustomizations": {
    "[Nord]": {
      "list.activeSelectionIconForeground": "#2e3440",
    }
  }

If wanted, I can open a PR.

[svengreb]

Thank you for your patience! 🙏🏼 It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the queue in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.

---

@GabrielRMuller @fspoettel Thanks again for your contributions 🚀 The issue has been added to the queue to be planned for the next iterations!

[GabrielRMuller]

Hi, glad to see Nord is still being supported, I still use it! :D

I'll be on the lookout for any open issues I might be able to help.