vim icon indicating copy to clipboard operation
vim copied to clipboard

Auto set cursorline option when line number background config is active

Open iysheng opened this issue 4 years ago • 3 comments

Resolves #141

auto set cursorline when

let g:nord_cursor_line_number_background = 1

to reslove issue141 that don't show properly at some point

iysheng avatar Feb 05 '20 13:02 iysheng

Hi @iysheng :wave:, thanks for your contribution :+1: I'll review the changes in the near future and get back to you. My first thought was that a theme should not set any properties except highlighting groups, otherwise it can mess with the configuration of the user causing unexpected side-effects, but I'll check it out later if this one might be fine in most cases.

arcticicestudio avatar Feb 06 '20 04:02 arcticicestudio

Hi @iysheng wave, thanks for your contribution +1 I'll review the changes in the near future and get back to you. My first thought was that a theme should not set any properties except highlighting groups, otherwise it can mess with the configuration of the user causing unexpected side-effects, but I'll check it out later if this one might be fine in most cases.

:smile: ok,thanks for your patient answer.

iysheng avatar Feb 06 '20 06:02 iysheng

@iysheng Thank (again!) you for your patience! 🙏🏼 It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added for triage in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@iysheng Thanks again for your contribution 🚀 The pull request has been added for triage and the review will be planned for the next iterations!

svengreb avatar Jun 21 '23 06:06 svengreb