matrix-neoboard icon indicating copy to clipboard operation
matrix-neoboard copied to clipboard

Hide about menu item if the widget is embedded

Open ahmadkadri opened this issue 1 year ago • 2 comments

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages (more info).
  • [ ] Added or updated documentation.
  • [ ] Tests for new functionality and regression tests for bug fixes.
  • [ ] Screenshots or videos attached (for UI changes).
  • [x] All your commits have a Signed-off-by line in the message (more info).

ahmadkadri avatar Sep 30 '24 11:09 ahmadkadri

🦋 Changeset detected

Latest commit: ed3285861fa7f9d83e8623c693095a6843358330

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nordeck/matrix-neoboard-widget Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 30 '24 11:09 changeset-bot[bot]

🤔 I am not sure if an environment variable is the way to go. But I am happy to discuss it.

When I discussed this PR with Ahmad, this was an option we considered as well.

The current status is that we have a couple more env vars that configure the widget, such as REACT_APP_HELP_CENTER_URL and REACT_APP_HOME_SERVER_URL, so given the low effort of adding yet another env var, it seemed reasonable.

I think having an embedded property in LayoutProps is a good option but as we are still discovering what new behaviours we should adjust for in the Widget, maybe this can slide thru as is?

I mean, will embedded only affect the canvas layout? Maybe it will have other non-layout related changes associated with it in the future..

Regardless of how it's implemented, what is missing in this PR is the documentation of how this flag affects the widget.

mgcm avatar Oct 07 '24 16:10 mgcm