caniuse-shortcode icon indicating copy to clipboard operation
caniuse-shortcode copied to clipboard

Wrong data shown for writing-mode

Open crnacura opened this issue 7 years ago • 12 comments

I noticed that the data for writing-mode is not shown correctly:

https://tympanus.net/codrops/css_reference/writing-mode/ (bottom of the page)

The version number for Chrome and Safari are wrong and seems to "stop" at the "unknown" value.

Seems like the parsing of the JSON is somehow not correct...

Thanks in advance!

crnacura avatar May 19 '17 10:05 crnacura

@crnacura can you test against the branch I just pushed?

norcross avatar May 21 '17 15:05 norcross

It does show the first version that's supports it now, but with a prefix.

Can I use Embed Problem

It should show the first version that supports it unprefixed though, i.e. Chrome 48: http://caniuse.com/#search=writing-mode. Btw, this seems to be a problem for all properties that were first supported with a prefix, e.g.: https://tympanus.net/codrops/css_reference/border-radius/

Thanks!

crnacura avatar May 22 '17 08:05 crnacura

that's what I was afraid of. Seems I've not been parsing the data correctly. I'll need to change how I do it.

norcross avatar May 22 '17 10:05 norcross

Let me know whenever I can help with testing. Thanks!

crnacura avatar May 22 '17 11:05 crnacura

@crnacura take another peek at that branch. I totally refactored how the data is constructed and verification checks are done

norcross avatar May 22 '17 13:05 norcross

@norcross Looks good! https://tympanus.net/codrops/css_reference/writing-mode/ Thanks a lot, really appreciate it!

crnacura avatar May 22 '17 15:05 crnacura

awesome. can you check a few others to confirm?

norcross avatar May 22 '17 17:05 norcross

These ones look good (no prefixed version): https://tympanus.net/codrops/css_reference/border-radius/ https://tympanus.net/codrops/css_reference/animation/ https://tympanus.net/codrops/css_reference/box-sizing/

This one looks good, too (Safari, prefixed version): https://tympanus.net/codrops/css_reference/background-blend-mode/ http://caniuse.com/#feat=css-backgroundblendmode

But this one does not seem right: https://tympanus.net/codrops/css_reference/mask-repeat/ See the Can I Use one here: http://caniuse.com/#feat=css-masks It's a special case where there is only partial support with a prefix (for Chrome).

crnacura avatar May 22 '17 17:05 crnacura

thanks. I'll check that one out in particular.

norcross avatar May 22 '17 19:05 norcross

ok. think I've got them all covered now. I'm merging the branch and updating the version number now.

norcross avatar May 23 '17 11:05 norcross

Thanks again for fixing this. I just noticed that a partially supported property (IE) is shown as "no support": https://tympanus.net/codrops/css_reference/custom-properties/

http://caniuse.com/#feat=css-variables

Do you think it has to do with the same problem? Thanks

crnacura avatar Jun 22 '17 10:06 crnacura

perhaps but I'd need to see.

norcross avatar Jun 23 '17 13:06 norcross