trello icon indicating copy to clipboard operation
trello copied to clipboard

Added ability to send all params through addListToBoard

Open joshterrill opened this issue 7 years ago • 3 comments

There are more than just the name parameter that can be sent through to the addListToBoard() API endpoint. So I generically made it so that you can pass an object of parameters through to this method. It's also backwards compatible so it doesn't break anyone else as it does a type check on the param coming through, if it's a string, it assumes you're sending a name through, if it's an object, it sets the query variable equal to what's coming through.

joshterrill avatar Oct 02 '18 19:10 joshterrill

Hi @joshterrill, Thank you very much for your contribution. Can you please add a test for your changes? Thank you so much.

norberteder avatar Oct 10 '18 07:10 norberteder

@norberteder Sure thing. I didn't see a test written for the original method so I thought to leave it alone. I can write a test for it, though.

joshterrill avatar Oct 12 '18 01:10 joshterrill

@norberteder I added a unit test for the addListToBoard that I modified.

joshterrill avatar Oct 12 '18 22:10 joshterrill

This wasn't merged? Or is this just a byproduct of you removing master and moving to main?

joshterrill avatar May 14 '23 17:05 joshterrill