NopSCADlib icon indicating copy to clipboard operation
NopSCADlib copied to clipboard

Published 20 hours ago • verified publisher icon nophead

Should polyholes and teardrops be in core?

Open martinbudden opened this issue 2 years ago • 4 comments

Currently polyholes.scad and teardrops.scad are included in utils/global.scad which is included in utils/core.scad.

I don't think polyholes and teardrops are core - they are only used in printed objects, not vitamins.

I think test have shown that the parsing of include files does have an impact on build times, so I think these two files should be move out of core.

Thoughts?

martinbudden avatar Jun 30 '22 15:06 martinbudden

Are they not used rather than included?

nophead avatar Jun 30 '22 16:06 nophead

No, they are included.

martinbudden avatar Jun 30 '22 17:06 martinbudden

That is because global.scad is only used. So all the includes in it get pasted together, parsed once and cached as one entry in the module cache.

nophead avatar Jun 30 '22 23:06 nophead

I am minded to close this as I don't think parsing these two files once per build is significant and they are probably used in some vitamins that have modules to make mounting holes for themselves.

nophead avatar Jul 18 '22 08:07 nophead