nopCommerce icon indicating copy to clipboard operation
nopCommerce copied to clipboard

Published 20 hours ago • verified publisher icon nopSolutions

Address attribute warning message localization

Open chensiel opened this issue 1 year ago • 3 comments

https://github.com/nopSolutions/nopCommerce/blob/6b30a973ef1b60756615ac25453d2aa56f4da700/src/Libraries/Nop.Services/Attributes/AttributeParser.cs#L411

In this method, use "ShoppingCart.SelectAttribute" for localization.

It will display wrong message for fields such as textbox.

chensiel avatar Mar 05 '23 05:03 chensiel

@chensiel What exactly do you mean by "wrong message"? What should be displayed?

AndreiMaz avatar Mar 05 '23 05:03 AndreiMaz

@chensiel What exactly do you mean by "wrong message"? What should be displayed?

If it's a textbox field, it should display 'Please enter {0}'. Now it display 'Please select {0}'.

chensiel avatar Mar 05 '23 13:03 chensiel

We'll think how we should better handle it. In the meantime you can enter some more generic locale value. For example, "Please ensure that "{0}" is specified"

AndreiMaz avatar Mar 06 '23 09:03 AndreiMaz