nopCommerce
nopCommerce copied to clipboard
nopSolutions
Allow editing of billing and shipping addresses for customers during checkout
nopCommerce version: 4.40.x and above
Steps to reproduce the problem:
- Go through the checkout and create two different addresses (one for billing & one for shipping)
- Make sure your addresses are correctly created (i.e. by creating an order)
- Now imagine that your part of your company moved, the billing address should be the same, but the shipping address should change
- Now you would leave the billing address the same, and only edit the shipping address
- You will see that you can only edit billing addresses, editing shipping addresses is apparently not possible at the moment.
"editing shipping addresses is apparently not possible"
@manuel3108 what exactly do you mean not possible? just enter a new address on the "Shipping address" step during checkout
@AndreiMaz Yeah, but during checkout you have the possibility to edit your billing address. But the possibility to edit an existing shipping address is not available.
Below is a screenshot showing a button to edit a billing addresses
But the button (and the functionality behind it) does not exist for shipping addresses:
Sure, you could just create a new address, but that's often not what you want. That's why I suggest adding the functionality, to also edit shipping addresses.
Is there order historical reasons not to edit a ship to address?
From: Manuel @.> Sent: Monday, December 20, 2021 12:37:22 AM To: nopSolutions/nopCommerce @.> Cc: Subscribed @.***> Subject: Re: [nopSolutions/nopCommerce] shipping address cannot be edited (Issue #6039)
@AndreiMazhttps://github.com/AndreiMaz Yeah, but during checkout you have the possibility to edit your billing address. But the possibility to edit an existing shipping address is not available.
Below is a screenshot showing a button to edit a billing addresses [grafik]https://user-images.githubusercontent.com/30698007/146736924-ec13faca-227e-4bbf-b1c4-de81dd307a89.png
But the button (and the functionality behind it) does not exist for shipping addresses: [grafik]https://user-images.githubusercontent.com/30698007/146737161-5b97a46e-e499-41b4-9976-3c0ca8a42811.png
Sure, you could just create a new address, but that's often not what you want. That's why I suggest adding the functionality, to also edit shipping addresses.
— Reply to this email directly, view it on GitHubhttps://github.com/nopSolutions/nopCommerce/issues/6039#issuecomment-997709465, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKD4KO6J4YNX2Y2MXZG2IRLUR3TMFANCNFSM5KIIX6RA. You are receiving this because you are subscribed to this thread.Message ID: @.***>
I don't know of any reason that's why I created this issue. At this point the order is not even created, so I cannot imagine of any reason
I meant if editing an address on the fly and it was associated to a prior order.
From: Manuel @.> Sent: Monday, December 20, 2021 8:03:35 AM To: nopSolutions/nopCommerce @.> Cc: Gregory Hays @.>; Comment @.> Subject: Re: [nopSolutions/nopCommerce] shipping address cannot be edited (Issue #6039)
I don't know of any reason that's why I created this issue. At this point the order is not even created, so I cannot imagine of any reason
— Reply to this email directly, view it on GitHubhttps://github.com/nopSolutions/nopCommerce/issues/6039#issuecomment-998057671, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKD4KO6GXBSQK6S4YCUZJSTUR5HVPANCNFSM5KIIX6RA. You are receiving this because you commented.Message ID: @.***>
Thats a good point, but i guess that you could argue with the same argument why the billing address is editable.
Maybe we should change the question and ask why we have an inconsistent behaviour between the editing of billing and shipping addresses.
Just checked some of the major platforms they allow editing during the checkout progress, so yes why the inconsistencies here?
From: Manuel @.> Sent: Monday, December 20, 2021 8:57:13 AM To: nopSolutions/nopCommerce @.> Cc: Gregory Hays @.>; Comment @.> Subject: Re: [nopSolutions/nopCommerce] shipping address cannot be edited (Issue #6039)
Thats a good point, but i guess that you could argue with the same argument why the billing address is editable.
Maybe we should change the question and ask why we have an inconsistent behaviour between the editing of billing and shipping addresses.
— Reply to this email directly, view it on GitHubhttps://github.com/nopSolutions/nopCommerce/issues/6039#issuecomment-998104481, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKD4KO6VT7MNGQ2L6DLIJBDUR5N6TANCNFSM5KIIX6RA. You are receiving this because you commented.Message ID: @.***>
Hi, @manuel3108. By default, editing the billing address is available only for unregistered users, solely for their convenience when placing multiple orders, we do not think that it is possible that the user will change the delivery address during the lifetime of the guest token. For registered users, we do not offer to edit even a billing address, since it is important for us to keep the complete history of user orders. If it is necessary to change the addresses, the customer just needs to create a new one.
Closed #6039
Ok, that's a valid point. But we should probably still consider allowing to edit an address, even if we just clone the address in the background.
@skoshelev During my workaround for this issue, I found out that this no longer seems to be true:
For registered users, we do not offer to edit even a billing address, since it is important for us to keep the complete history of user orders.
As I found out during my debugging session is that during checkout the addresses are already cloned to preserve order history. See here.
https://github.com/nopSolutions/nopCommerce/blob/a3e1426c0269225cc06bfd3cd27223596b4c0dd4/src/Libraries/Nop.Services/Orders/OrderProcessingService.cs#L505
https://github.com/nopSolutions/nopCommerce/blob/a3e1426c0269225cc06bfd3cd27223596b4c0dd4/src/Libraries/Nop.Services/Orders/OrderProcessingService.cs#L606
I would propose that we re-open this issue, change the title to something to "allow editing of billing and shipping addresses for registered users" and treat this as a feature request.
Hi, @manuel3108. Thank you for suggestions, I'll reopen this ticket to analyze it in more details