nopCommerce icon indicating copy to clipboard operation
nopCommerce copied to clipboard

Add Skip link/Bypass block

Open dylanhthomas opened this issue 4 years ago • 4 comments

This resolves the missing skip link issue. If you navigate to any page, the link will be invisible. If you hit tab one time, you will see the below link. If you tab again, it will disappear. If you click or hit enter on the link, the focus will jump to the next focusable link in the main section.

skiplink

dylanhthomas avatar Sep 15 '20 01:09 dylanhthomas

should close #5023

dylanhthomas avatar Sep 15 '20 02:09 dylanhthomas

Hi @dylanhthomas,

I'm testing your solution and when I click "Enter" on the added link it doesn't jump to the main content block. Am I missing anything?

mariannk avatar Oct 09 '20 10:10 mariannk

You need to hit 'tab' again to select the next link. the link moves the focus to the div (which isn't focusable) This is the expected behavior.

There is a bit of an issue testing on the homepage, since the nivo slider has it's own focus styles and does not inherit from the main stylesheet (I will be fixing this in the future).

I've attached a video demoing on the homepage and an internal page.

Let me know if I can help more or if this does the trick.

https://youtu.be/6UAPDHVLrxU

dylanhthomas avatar Oct 12 '20 19:10 dylanhthomas

@dylanhthomas I recorded a video from my PC to show you that for some reasons it doesn't work for me https://youtu.be/bdyX0X-quQo

mariannk avatar Nov 11 '20 12:11 mariannk

Thanks. We've used your suggestion in this commit.

RomanovM avatar Mar 21 '23 10:03 RomanovM